946213 - [builds] Kill the app after flashing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Julien Wajsberg [:julienw]]

The main issue is when flashing the Homescreen app:

The homescreen needs to be flashed twice to see the changes. That happens because we kill the app before flashing it, and the homescreen is automatically restarted before the new code is in.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Pull request is: https://github.com/mozilla-b2g/gaia/pull/14362

* kill the flashed app after flashing
* use a target-scoped var for TARGET_FOLDER
* use non-recursive vars for APP_NAME and APP_PID, because they're used at
  several places and it makes no sense to run them each time
---
 Makefile |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8342372 [details] [diff] [review]
patch v1

Review of attachment 8342372 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Note that it conflicts with:
https://github.com/mozilla-b2g/gaia/commit/fc8e139334901fc4cb49cc124a14ef557e260cba

Comment 3

[Julien Wajsberg [:julienw]]

Travis is green after rebase!

master: 1997c55ce6e6f74329a5d8bb8c223af56cc4674c