Closed
Bug 946222
Opened 9 years ago
Closed 9 years ago
Touch events don't work on gaia without gaia addon
Categories
(DevTools :: Responsive Design Mode, defect)
DevTools
Responsive Design Mode
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
1.57 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
For now, gaia instanciates TouchEventHandler on its own, via its helper addon and totally bypass Responsive mode touch event button/codepath. I'd like to have only one codepath for touch event support on Firefox, unfortunately, Reponsive mode codepath doesn't work yet with gaia. That's because we should listen for mouse events on the frame (ie the <browser> element), not on the content window.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=1c2aeb39ca84
Assignee | ||
Updated•9 years ago
|
Attachment #8342376 -
Flags: review?(paul)
Comment 2•9 years ago
|
||
Comment on attachment 8342376 [details] [diff] [review] Listen on browser, not content window What about using the chromeEventHandler in touch-events.js instead? > let chromeEventHandler = window.QueryInterface(Ci.nsIInterfaceRequestor) > .getInterface(Ci.nsIWebNavigation) > .QueryInterface(Ci.nsIDocShell) > .chromeEventHandler;
Attachment #8342376 -
Flags: review?(paul) → review-
Comment 3•9 years ago
|
||
Comment on attachment 8342376 [details] [diff] [review] Listen on browser, not content window Talked to Alex. It's up to the consumer to make sure we pass a chromeEventHandler.
Attachment #8342376 -
Flags: review- → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3b6eb557374c
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b6eb557374c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•