Closed Bug 946231 Opened 6 years ago Closed 6 years ago

Enables touch events on firefox via the responsive mode

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
For now, we have been instanciating devtools TouchEventHandler from desktop helper. But it messes up with the responsive mode, that also instanciate it if you press the touch event button.

But the main reason is for the sake of maintainability. We should prevent having multiple codepath for the exact same thing.
So I'm fixing responsive mode code in bug 946222, in order to just toggle touch event support via the responsive mode itself.
Assignee: nobody → poirot.alex
Depends on: 946222
Attached file Pull request 14363
This patch depends on bug 946222, so we should wait for it to reach nightly before landing this patch.
Attachment #8342397 - Flags: review?(kgrandon)
Blocks: 891882
Comment on attachment 8342397 [details] [review]
Pull request 14363

Sounds good to me. Unification!
Attachment #8342397 - Flags: review?(kgrandon) → review+
master:
https://github.com/mozilla-b2g/gaia/commit/9c907e5d2bc10a259ea609957891f569c333a017
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.