Closed
Bug 946232
Opened 11 years ago
Closed 11 years ago
span.toggle that opens/closes the menu should be inside the nav-element
Categories
(www.mozilla.org :: Information Architecture & UX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: icaaq, Unassigned)
Details
(Whiteboard: [kb=1321907] )
Sorry about this but we should revert this commit https://github.com/mozilla/bedrock/commit/4ea586fc275456a842c00939e65e8baa322f20e9 that was a solution on bug 768636 that I filed. The reason is this:
1. When using Voice over and Safari press Cmd+N to open a new browser window, then type https://www.mozilla.org/en-US/ in the address bar and press Enter
2. Resize the browser to < 760px
3. Press VO + U to open the webrotor
4. Press arrow left until you get to landmarks
5. See/hear that there is a navigational landmark.
6. Select navigation and press enter
7. Hear that nothing is announced (it's empty)
By reverting the commit we will move the menu button inside of the navigation landmark again.
Comment 1•11 years ago
|
||
icaaq, do we still need to revert this commit?
Reporter | ||
Comment 2•11 years ago
|
||
malexis, it should be fixed :) either by reverting the commit, if that's even possible now or a new PR
Updated•11 years ago
|
Flags: needinfo?(icaaaq)
Whiteboard: [kb=1321907]
Reporter | ||
Comment 3•11 years ago
|
||
Flags: needinfo?(icaaaq)
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/4914d92a32cd03b3374ba587380d5446eb1698fc
fixes bug 946232 moved span.toggle inside on <nav>
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•