Closed Bug 94624 Opened 23 years ago Closed 23 years ago

popups opened via script don't set document.popupNode

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

VERIFIED INVALID

People

(Reporter: hewitt, Assigned: hewitt)

Details

Attachments

(1 file)

When popups are opened via nsXULPopupListener, the document.popupNode property
is set to indicate the element that was the target of the popup.  However, if
you open a popup via nsIPopupSetBoxObject::createPopup, this property will not
be set.  

This has the side effect of causing said popups to be occasionally mis-aligned,
because nsMenuPopupFrame uses the document.popupNode property to get the widget
of the target document in order to calculate screen coordinates for positioning
the popup.

I suspect this may also be the cause of the bug that causes the autocomplete
popup to be painted in the wrong place.

Patch forthcoming...
Attached patch patch to fixSplinter Review
reviews anyone?
Status: NEW → ASSIGNED
Summary: popups opened via script don't set document.popupNode → popups opened via script don't set document.popupNode
nevermind, found a better way to do this. invalid.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → INVALID
Make it so.
Status: RESOLVED → VERIFIED
so does this 'better way to do it' fix the problem where the autocomplete would 
come up at the wrong place when it didn't have any completions?
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: