946260 - [Contacts] Broken link image shown for contacts when scrolling instead of their photo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

TO REPRODUCE:

Use Gecko-c5fbc5c and master Gaia as for now :)
1. Open de Contacts app.
2. Import some contacts, probably synchronizing with some Facebook account.
3. Scroll the list of contacts (you can do it up and down continuously without releasing it).

EXPECTED:
4. The photos of the contacts out of the viewport are not shown (a blank space is shown instead) to increase the performance of the scrolling. The photos are reloaded once the scrolling finishes.

OBSERVED:
4. The photos of the contacts out of the viewport are not shown (anyhow, a "broken link ghost image is shown instead" (see attachment)) to increase the performance of the scrolling. The photos are reloaded once the scrolling finishes.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: device-2013-12-04-151959.png

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Hi Vicky, could you confirm that a blank space should be shown instead of the "broken link image" shown in the attachment, please? Thanks!

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Changing the need-info to Mr. Vittone... ;-)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Do we have patch for this?

Comment 5

[José Vittone]

Hi guys,

I guess that a blank space would be correct, but if an image would take that space once loaded it should be reserved to that purpose. I mean, do not allow the text to flow if an image is coming, in order to avoid the movement. 

Am I clear?

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Yeap! Thanks Jose.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ for "broken link ghost image is shown instead"

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 14840.html

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8349973 [details]
14840.html

thanks for the patch. Check Travis if none of the errors are due to this patch, merge, please

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/ae731e303597aac1cb00657e5e60e4e9f58f4013 Thanks!

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted ae731e303597aac1cb00657e5e60e4e9f58f4013 to:
v1.3: 5d39cda85d65a77ba5dfcd8576fb2dcf75feea27