946277 - nose weirdly configured for tests exclusion

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Mathieu Agopian [:magopian]]

When naming a test with "mkt" in it, this test won't be run with AMO settings.

It seems to be caused by this line: https://github.com/mozilla/zamboni/blob/master/lib/settings_base.py#L456

This line, however, is weird because:
* it's not a proper regex (while the docs says it should be), or at least it's a regex matching on "mkt" and 0 or many slashes (is that what we want?)
* it looks like it's trying to exlude all files from the mkt/ folder, but then, it should use the "-I --ignore-files" option, not the "-e --exclude" option

So:
1/ should we skip tests that contain "mkt" in their names? If so, we should just change this line to "--exclude=mkt"
2/ should we skip test files that are in the "mkt/" folder? If so, we should change this line to "--ignore-files=mkt"

Regarding the first question, I'd personally favor explicitly skipping tests that we want to skip using "nose.exc.skipTest".

Comment 1

[Mathieu Agopian [:magopian]]

This bug isn't relevant anymore, as there's been a split between amo and zamboni (also called the "guillotine"), resulting in a new standalone repository for AMO named "olympia".