Closed Bug 946326 Opened 9 years ago Closed 9 years ago

Dark theme gutter is transparent

Categories

(DevTools :: Source Editor, defect)

Product:
DevTools
Component:
Source Editor
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: fitzgen, Assigned: bgrins)

Details

(Whiteboard: [good first verify])

Attachments

(3 files)

dark theme
124.27 KB, image/png
Details
light theme
78.25 KB, image/png
Details
theme-editor-gutters.patch
2.31 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review
Attached image dark theme — 
The source editor gutter is transparent in the dark theme but not the light theme.
Attachment #8342497 - Attachment description: Screen Shot 2013-12-04 at 10.06.00 AM.png → dark theme
> The source editor gutter is transparent in the dark theme but not the light
> theme.

Is the suggestion that the dark one should be opaque or that the light one should be transparent?
I'd assume opaque. Sorry for not being clear.
This replaces the gutter colors with the "Editor - Sidebar" colors from: https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8342615 - Flags: review?(nfitzgerald)
Attachment #8342615 - Flags: review?(nfitzgerald) → review+
https://hg.mozilla.org/mozilla-central/rev/4804c17a1fd5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.