946352 - Remove go button workaround in ToolbarComponent.commitEditingMode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Once bug 945521 is solved.

The workaround was introduced in bug 910859 part 3.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The code to change is in ToolbarComponent.commitEditingMode.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Spoke with Sebastian on IRC.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Okay. I used this bug to get into building and running the tests..

If I'm correct ToolbarComponent.commitEditingMode() is only used in NavigationHelper.enterAndLoadUrl() and this method is only called from two tests: testSessionHistory and testAboutHomeVisibility.

Both tests passed before and after removing the workaround. According to the linked bugs the workaround was for HTC phones and phones running SwiftKey. So I ran the tests on a HTC Sensation XL and a Nexus 7 with SwiftKey installed. The tests passed on these devices as well after removing the workaround.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 946352.patch

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8370911 [details] [diff] [review]
946352.patch

Review of attachment 8370911 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! Thanks for the help! :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1db74bba1ae6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1db74bba1ae6