Closed Bug 946352 Opened 6 years ago Closed 6 years ago

Remove go button workaround in ToolbarComponent.commitEditingMode

Categories

(Firefox for Android :: Testing, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: mcomella, Assigned: sebastian)

References

Details

(Whiteboard: [mentor=mcomella][lang=java])

Attachments

(1 file)

Once bug 945521 is solved.

The workaround was introduced in bug 910859 part 3.
The code to change is in ToolbarComponent.commitEditingMode.
Whiteboard: [mentor=mcomella][lang=java]
Spoke with Sebastian on IRC.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Okay. I used this bug to get into building and running the tests..

If I'm correct ToolbarComponent.commitEditingMode() is only used in NavigationHelper.enterAndLoadUrl() and this method is only called from two tests: testSessionHistory and testAboutHomeVisibility.

Both tests passed before and after removing the workaround. According to the linked bugs the workaround was for HTC phones and phones running SwiftKey. So I ran the tests on a HTC Sensation XL and a Nexus 7 with SwiftKey installed. The tests passed on these devices as well after removing the workaround.
Attached patch 946352.patchSplinter Review
Attachment #8370911 - Flags: review?(michael.l.comella)
Comment on attachment 8370911 [details] [diff] [review]
946352.patch

Review of attachment 8370911 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! Thanks for the help! :)
Attachment #8370911 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/integration/fx-team/rev/1db74bba1ae6
Keywords: checkin-needed
Whiteboard: [mentor=mcomella][lang=java] → [mentor=mcomella][lang=java][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1db74bba1ae6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=mcomella][lang=java][fixed-in-fx-team] → [mentor=mcomella][lang=java]
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.