Closed Bug 946452 (rocketbar-search-mvp) Opened 6 years ago Closed 5 years ago

[meta] MVP Rocketbar Search App

Categories

(Firefox OS Graveyard :: Gaia::Search, defect, P1)

defect

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: kgrandon, Unassigned)

References

()

Details

(Whiteboard: [c= p= s= u=] [systemsfe][2.1-feature-qa+])

User Story

Latest Interaction specs for Rocket bar are available at:  https://etherpad.mozilla.org/SFE-Spec-Locations

Attachments

(1 file)

Opening this as a tracking bug for any rocketbar work that happens now.

I am considering this specifically for the search/E.me story, and will not be tracking BrowserOS features here.
Depends on: 942175
Depends on: 946455
Depends on: 946533
Depends on: 946884
Depends on: 946904
Depends on: 948010
Depends on: 948461
Depends on: 949242
Changing the name of the bug to indicate that this bug tracks the work of the Rocketbar search app which is responsible for rendering results as you type, as distinct from the Rocketbar itself which is part of the system app and tracked by the System::Browser Chrome component.

The Rocketbar communicates with the Rocketbar search app via the inter-app communications API.

Once the architecture and where the code lives is a bit more stable we should consider adding a Bugzilla component for this app.
Summary: [meta] Rocketbar Search Story → [meta] Rocketbar Search App
No longer depends on: 948302
No longer depends on: 948308
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Depends on: 950569
Landed in feature branch: https://github.com/mozilla-b2g/gaia/commit/e829b6897c64529b056cf62cc019847a19d672bd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 950686
I resolved the wrong bug earlier. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 950720
Whiteboard: [c= p= s= u=] → [c= p= s= u=] [systemsfe]
Depends on: 951140
Depends on: 951158
Depends on: 951179
Depends on: 951217
Depends on: 948302
Depends on: 951711
Depends on: 951721
Depends on: 945938
Depends on: 952097
Depends on: 952098
Initial work has landed in master behind a preference: https://github.com/mozilla-b2g/gaia/pull/14839
Attached file Browser Chrome Bugs
The browser chrome bugs are especially important for rocketbar to function well. Adding this link as an attachment here so people can find them easily.
Depends on: 952158
No longer depends on: 948010
Depends on: 952415
Depends on: 952441
Depends on: 941176
Depends on: 953293
Depends on: 955713
Depends on: 956076
No longer depends on: 948313
Depends on: 956393
Target Milestone: 1.3 C1/1.4 S1(20dec) → 1.3 C2/1.4 S2(17jan)
No longer depends on: 948320
Depends on: 957792
Depends on: 957930
No longer depends on: 952098
No longer depends on: 952415
No longer depends on: 957930
No longer depends on: 948310
We now have the Gaia::Search component for this
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → INVALID
I'm reopening this bug just to help identify the 1.4 MVP user stories for Rocketbar.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: [meta] Rocketbar Search App → [meta] MVP Rocketbar Search App
Alias: rocketbar-mvp
Depends on: 966891
Depends on: 966893
Depends on: 966900
Depends on: 966899
Depends on: 966902
Depends on: 966908
Depends on: 966901
No longer depends on: 966901
Depends on: 966915
Depends on: 966975
Depends on: 966993
Depends on: 967162
Depends on: 966586
No longer depends on: 966891
No longer depends on: 967162
Depends on: 966475
Depends on: 952415
Depends on: 967162
No longer depends on: 967162
Depends on: 966901
No longer depends on: 966901
Depends on: 948310
Depends on: 960121
No longer depends on: 941176
Depends on: 967187
Depends on: 966945
Depends on: 967420, 967421, 967428
No longer depends on: 948310
Depends on: 967450
No longer depends on: 966993
Depends on: 967563
Depends on: 967717
Depends on: 967772
Depends on: 967848
Depends on: 967854
Depends on: 967903
Depends on: 968040
Depends on: 967760
No longer depends on: 967772
Component: Gaia → Gaia::Search
Depends on: 962795
Depends on: 968103
Target Milestone: 1.3 C2/1.4 S2(17jan) → ---
Depends on: 968382
No longer depends on: 967717
Depends on: 967772
No longer depends on: 948316
No longer depends on: 948312
No longer depends on: 967450
Depends on: 969082
Depends on: 969420
Depends on: 970621
No longer depends on: 970621
Depends on: 971029
Depends on: 972163
No longer depends on: 969420
Depends on: 975007
Depends on: 975184
Hi Kevin, here's a link to the visual specs I have so far for Rocket Bar search results.
https://mozilla.box.com/s/a2rm3h73dazaphqs7hgc

When revisions are made I'll update the files at the link and let you know.  If any specific specs are needed or if there are any questions please let me know :).  Thanks!
Depends on: 975491
Depends on: 975130
No longer depends on: 967760
Depends on: 978736
Priority: -- → P1
Latest Interaction specs for Rocket bar are available at: https://mozilla.box.com/s/2tix674298wtc4e4hewh
User Story: (updated)
User Story: (updated)
Depends on: 996044
User Story: (updated)
Depends on: 1021415
Depends on: 1021401
Depends on: 1021417
Depends on: 1021731
Depends on: 1021857
No longer depends on: 1021857
Depends on: 1021416
No longer depends on: 1021416
No longer depends on: 1021417
No longer depends on: 1021401
No longer depends on: 1021415
No longer depends on: 1021731
Depends on: 1027358
No longer depends on: 1027358
Depends on: 1021779
Depends on: 959722
No longer depends on: 959722
Depends on: 1026031
Depends on: 1038726
Depends on: 1039184
Depends on: 1039189
Depends on: 1039201
Depends on: rocketbar-dogfood
No longer depends on: 1039201
No longer blocks: 1009351
Depends on: 1009351
Assignee: kgrandon → nobody
See Also: → browser-chrome-mvp
Depends on: 1041371
Depends on: 1041372
Depends on: 1041373
Depends on: 1041376
Depends on: 1041379
Depends on: 1041380
Depends on: 1041482
Updated links for RocketBar Search in user story.  RB visuals will be updated soon.
User Story: (updated)
User Story: (updated)
Depends on: 1042012
Added a link to the search suggestion pop up visual spec
https://mozilla.box.com/s/l81uu29pb9pwfo6ldk1u
User Story: (updated)
Updated the User story to point to UX spec locations at:  https://etherpad.mozilla.org/SFE-Spec-Locations
User Story: (updated)
Depends on: 1045805
Depends on: 1045817
Depends on: 1045894
Depends on: 1039727
Depends on: 1046908
Depends on: 1047255
Depends on: 1048100
Depends on: 1047988
Depends on: 1048308
Depends on: 1047325
Depends on: 1041320
Depends on: 1041620
Depends on: 1048629
QA Whiteboard: [2.1-feature-qa+]
Depends on: 1048991
Depends on: 1048777
Depends on: 1049143
Flags: in-moztrap?(nhirata.bugzilla)
QA Contact: nhirata.bugzilla
QA Whiteboard: [2.1-feature-qa+]
Whiteboard: [c= p= s= u=] [systemsfe] → [c= p= s= u=] [systemsfe][2.1-feature-qa+]
No longer depends on: 1039727
Depends on: 1050868
Depends on: 1051513
Depends on: 835152
Flags: in-moztrap?(nhirata.bugzilla) → in-moztrap?(mozillamarcia.knous)
QA Contact: nhirata.bugzilla → mozillamarcia.knous
Depends on: 1052097
Depends on: 1052488
Depends on: 1052481
Depends on: 1052492
Depends on: 1053610
Depends on: 1053626
No longer depends on: 1045805
No longer depends on: 1050868
No longer depends on: 1052492
No longer depends on: 1038726
Depends on: 1053970
No longer depends on: 1039184
No longer depends on: 1041320
No longer depends on: 1021779
Depends on: 1054435
Depends on: 1054457
Depends on: 1054556
Depends on: 1054672
No longer depends on: browser-chrome-mvp
Depends on: 1048458
Alias: rocketbar-mvp → rocketbar-search-mvp
No longer depends on: 967420
Depends on: 962610
Depends on: 962612
No longer depends on: 1054556
No longer depends on: 1054672
No longer depends on: 996044
No longer depends on: 1052481
No longer depends on: 1052488
No longer depends on: 1041371
No longer depends on: 1041372
No longer depends on: 1041373
No longer depends on: 1041376
No longer depends on: 967428
No longer depends on: 967421
Depends on: 1054447
Depends on: 1053261
Depends on: 1053251
Depends on: 1052503
Depends on: 1054521
No longer depends on: 1052503
Kevin - Is the rocketbar feature complete at this point? Or do we have outstanding items we need to resolve? Just want to know if we can close this bug out at this point to indicate that we're finished with the feature work here or not.
Flags: needinfo?(kgrandon)
QA Whiteboard: [2.1-feature-slip?]
(In reply to Jason Smith [:jsmith] from comment #14)
> Kevin - Is the rocketbar feature complete at this point? Or do we have
> outstanding items we need to resolve? Just want to know if we can close this
> bug out at this point to indicate that we're finished with the feature work
> here or not.

Since this is not marked as feature-b2g I don't really see a benefit of closing this out, but we certainly can. There's a few polish bugs left which we'll move to block the rocketbar-mvp bug.
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Flags: needinfo?(kgrandon)
Resolution: --- → FIXED
No longer depends on: 1052097
No longer depends on: 1053261
No longer depends on: 1054457
(In reply to Kevin Grandon :kgrandon from comment #15)
> (In reply to Jason Smith [:jsmith] from comment #14)
> > Kevin - Is the rocketbar feature complete at this point? Or do we have
> > outstanding items we need to resolve? Just want to know if we can close this
> > bug out at this point to indicate that we're finished with the feature work
> > here or not.
> 
> Since this is not marked as feature-b2g I don't really see a benefit of
> closing this out, but we certainly can. There's a few polish bugs left which
> we'll move to block the rocketbar-mvp bug.

I can explain that. Closing this out helps out QA in the sense that it will show up in bug query for features need FL verification, which includes feature metas that contain a set of user stories. If I have this closed, then our QA team knows that they need to verify each user story involving the feature.
QA Whiteboard: [2.1-feature-slip?]
QA Whiteboard: [needs-verification]
I am verifying this bug as fixed for landing on both Flame 2.1(319mb) and 2.2(319mb)(master) according to the "Search App" section of this etherpad: https://etherpad.mozilla.org/SFE-Spec-Locations

- The user sees incremental results as they type in Rocketbar 
- Tapping on Rocketbar suggestions properly changes the users search
- When searching in the Rocketbar, the selected search provider page is opened with the search the user typed as expected
- Browser shows loading state after tapping the magnifying glass to signify the search is working
- Expanded rocket bar is shown after a search, as opposed to a collapsed rocketbar
- The keyboard pops up and the screen is dimmed when tapping on the Rocketbar
- Searching an app thats already open in the background will properly display the open app in the foreground, unless the search is a URL, in which case a new page is opened
- Searches will stay in the Rocketbar after tapping home button and then reopening rocketbar
- Search suggestions can be enabled/disabled properly
- Search suggestions pop up will disappear once a search is initiated or the user taps "ok"
- A loading symbol will appear when typing in the search bar
- "No internet connection" appears correctly when offline, and an icon to the settings app is shown and functions as expected
- Only local apps are shown when doing a search offline
- Tapping the "x" button will clear the search and search suggestions
- The search results grid is four icons across and seems to be spaced correctly

Flame 2.1

Environmental Variables:
Device: Flame 2.1
BuildID: 20140910000202 (319mb)
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140910040203
Gaia: 8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7
Gecko: 152ef25e89ae
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [needs-verification] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.