946480 - Run adb remount when installing apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

In bug 945903, we changed the default installation directory. Pushing apps after a make reset-gaia works fine, until you reboot the system. In this case the /system directory is now read-only and you can't push apps to it with make install-gaia APP=____ anymore.

Pushing manifest.webapp application.zip for homescreen...
failed to copy 'profile/webapps/homescreen.gaiamobile.org/manifest.webapp' to '/system/b2g/webapps/homescreen.gaiamobile.org/manifest.webapp': Read-only file system

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Pull request - run adb remount when installing apps

Hi Yuren - think you could give this a quick review? In this PR I run adb remount whenever installing an app. This isn't necessary 100% of the time, but it seems to be pretty quick so I don't think it's too terrible. Please let me know if you have any better ideas.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8342672 [details] [review]
Pull request - run adb remount when installing apps

we always need adb remount if we execute |make install-gaia|, please add a new make rule |adb-remount| and let |install-gaia| depend on it.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/14384

seems a little bit critial, steal it.

Comment 4

[Kevin Grandon :kgrandon]

Hmm, I don't really think that it was *that* critical, or critical to steal for a nit, but that's fine I suppose. Next time I would appreciate if you could check with me first. Thanks for that patch though!

Comment 5

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/6a20f5a8104e31e4dedf2fb4ce315ecbeb6d83a3

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Oh, Sorry for that. I think you are sleeping and you will fix this nit tomorrow, that's why I steal it.

Sorry again.