Don't cache "browser.snippets.enabled" value

RESOLVED FIXED in Firefox 28

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 28
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8342681 [details] [diff] [review]
patch

I know I said before that it was okay to cache this pref value, but if we do that, a bootstrapped add-on can't dynamically set the pref for testing.

I made an add-on that enables snippets, and sets the update url to my test snippets server. With this patch applied, it works (although it does still require a restart, probably to force the update timer to fire):
http://people.mozilla.org/~mleibovic/testsnippets.xpi
Attachment #8342681 - Flags: review?(bnicholson)
(Assignee)

Updated

4 years ago
Assignee: nobody → margaret.leibovic
Attachment #8342681 - Flags: review?(bnicholson) → review+
Status: NEW → ASSIGNED
Hardware: ARM → All
Summary: Don't cache "browser.snippests.enabled" value → Don't cache "browser.snippets.enabled" value
https://hg.mozilla.org/mozilla-central/rev/fb87b500de16
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.