Closed Bug 9465 Opened 25 years ago Closed 25 years ago

use CreateElementWithNameSpace() for anonymous content nodes

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: waterson, Assigned: eric)

Details

(Whiteboard: Back to engineer for verification...) 

Using just "CreateElement()" will break as soon as someone uses something
besides XUL for the default namespace. Use "CreateElementWithNameSpace()"
instead.
Status: NEW → ASSIGNED
Target Milestone: M9
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
I manually set the namespace via SetNameSpace.
Status: RESOLVED → REOPENED
That won't work right for HTML content.  You need to get the namespace right up
front.  I use this in nsMenuFrame.cpp when I make anonymous content.  It's
trivial for you to look at that and use it as a guide for switching your stuff
over.
Eric and I talked about this. In his case, I think it's okay for him to
manually create XML nodes (_not_ XUL nodes), and then just twiddle them
himself. Eric, this is what you're doing, isn't it?
Resolution: INVALID → ---
Clearing Invalid resolution due to reopen.
I don't make HTML or XUL content nodes. I use XML nodes... And it seems to work
fine. Am I missing something?
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Ok, that's fine then.
Whiteboard: Back to engineer for verification...
Chris, could you verify this?  Thanks!
-Chris
Status: RESOLVED → VERIFIED
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.