Closed Bug 946501 Opened 6 years ago Closed 5 years ago

Factory::CreateDrawTargetForData doesn't handle BACKEND_DIRECT2D

Categories

(Core :: Graphics, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: dmajor, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I keep seeing debug messages of "Invalid draw target type specified." at Factory::CreateDrawTargetForData. The aBackend parameter is BACKEND_DIRECT2D. It seems that this isn't handled by the switch statement.

gkmedias!mozilla::gfx::Factory::CreateDrawTargetForData
xul!gfxPlatform::CreateDrawTargetForData
xul!gfxAlphaBoxBlur::Init
xul!gfxAlphaBoxBlur::BlurRectangle
xul!nsContextBoxBlur::BlurRectangle
xul!nsCSSRendering::PaintBoxShadowOuter
xul!nsDisplayBoxShadowOuter::Paint
xul!mozilla::FrameLayerBuilder::PaintItems
xul!mozilla::FrameLayerBuilder::DrawThebesLayer
xul!mozilla::layers::ThebesLayerD3D10::DrawRegion
xul!mozilla::layers::ThebesLayerD3D10::Validate
xul!mozilla::layers::ContainerLayerD3D10::Validate
xul!mozilla::layers::LayerManagerD3D10::Render
xul!mozilla::layers::LayerManagerD3D10::EndTransaction
xul!nsDisplayList::PaintForFrame
xul!nsDisplayList::PaintRoot
xul!nsLayoutUtils::PaintFrame
xul!PresShell::Paint
Matt and I discussed this on irc and agreed that the way forward was to check in gfxPlatform::CreateDrawTargetForData for d2d and in that case not call Factory::CreateDrawTargetForData.
Blocks: 944571
Oh, and there is fallback in gfxAlphaBoxBlur::Init, so this is not causing any errors, just spurious warnings.
Attached patch Fix warningSplinter Review
Attachment #8344411 - Flags: review?(ncameron)
Attachment #8344411 - Flags: review?(ncameron) → review+
Is this still a relevant patch?
Flags: needinfo?(matt.woodrow)
Doesn't look like it, no.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(matt.woodrow)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.