946501 - Factory::CreateDrawTargetForData doesn't handle BACKEND_DIRECT2D

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[:dmajor]

I keep seeing debug messages of "Invalid draw target type specified." at Factory::CreateDrawTargetForData. The aBackend parameter is BACKEND_DIRECT2D. It seems that this isn't handled by the switch statement.

gkmedias!mozilla::gfx::Factory::CreateDrawTargetForData
xul!gfxPlatform::CreateDrawTargetForData
xul!gfxAlphaBoxBlur::Init
xul!gfxAlphaBoxBlur::BlurRectangle
xul!nsContextBoxBlur::BlurRectangle
xul!nsCSSRendering::PaintBoxShadowOuter
xul!nsDisplayBoxShadowOuter::Paint
xul!mozilla::FrameLayerBuilder::PaintItems
xul!mozilla::FrameLayerBuilder::DrawThebesLayer
xul!mozilla::layers::ThebesLayerD3D10::DrawRegion
xul!mozilla::layers::ThebesLayerD3D10::Validate
xul!mozilla::layers::ContainerLayerD3D10::Validate
xul!mozilla::layers::LayerManagerD3D10::Render
xul!mozilla::layers::LayerManagerD3D10::EndTransaction
xul!nsDisplayList::PaintForFrame
xul!nsDisplayList::PaintRoot
xul!nsLayoutUtils::PaintFrame
xul!PresShell::Paint

Comment 1

[Nick Cameron [:nrc]]

Matt and I discussed this on irc and agreed that the way forward was to check in gfxPlatform::CreateDrawTargetForData for d2d and in that case not call Factory::CreateDrawTargetForData.

Comment 2

[Nick Cameron [:nrc]]

Oh, and there is fallback in gfxAlphaBoxBlur::Init, so this is not causing any errors, just spurious warnings.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Fix warning

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this still a relevant patch?

Comment 5

[Matt Woodrow (:mattwoodrow)]

Doesn't look like it, no.