[Buri] Camera shows flash icon when no flash is supported

RESOLVED FIXED

Status

Firefox OS
Gaia::Camera
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: marcia, Assigned: wilsonpage)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [camera-refactor])

Attachments

(1 attachment)

38 bytes, text/x-github-pull-request
dmarcos
: review+
Details | Review | Splinter Review
buri, while running latest nightly (20131203121703) with Diego's branch:

STR:
1. Launch the camera
2. Observe that the flash icon shows and can be selected, but the Buri phone has no flash functionality
(Assignee)

Comment 1

5 years ago
Hoping i can recreate this on Hamachi as I don't have a Buri. Once fixed I will write a unit test against it to make sure this doesn't regress again.
Assignee: nobody → wilsonpage
(Assignee)

Comment 2

5 years ago
I was able to reproduce this on my Hamachi device. The flash logic was very complicated, so have simplified it and written unit tests against it. The fix it currently awaiting merge into Diego's refactor branch: https://github.com/dmarcos/gaia/pull/9.
(Assignee)

Comment 3

5 years ago
Created attachment 8343083 [details] [review]
Pull Request
Attachment #8343083 - Flags: review?(dmarcos)
Buri and Hamachi are the same hardware
Attachment #8343083 - Flags: review?(dmarcos) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.