Closed Bug 946520 Opened 11 years ago Closed 10 years ago

[B2G][SMS] The phone falling asleep while deleting a large number of messages causes multiple issues to occur

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v1.2 affected)

RESOLVED WORKSFORME
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: KTucker, Assigned: arnau)

Details

(Keywords: perf, Whiteboard: dogfood1.2[c= u=p= s=])

Attachments

(4 files)

Description:
If the phone falls asleep while deleting a large number of SMS and MMS messages, multiple issues will occur. The user will see a blank white screen followed by text overlapping the main messages screen when they wake the device back up. Also, sometimes either all messages won't be deleted or the user can still see an old message date header left on the main messages view screen. 

Repro Steps:
1)  Updated Buri to Build ID: 20131126004001
2)  Ensure the test phone has a mixture of 2000 SMS and MMS messages on it.
3)  Tap on the "Messages" icon.
4)  Tap on the "Check mark" to enter edit mode.
5)  Tap on "Select all" and then tap on the "Delete".
6)  Let the device fall asleep while the 2000 messages are being deleted.
7)  After the phone has fallen asleep, wake the phone up and observe what happens.
8) Let the phone fall asleep again while it is still deleting messages and then wake it back up.

Actual:
The screen will be white and then the main messages view will be shown which has overlapping text on the screen. Also, either an old date message header will be left on the main messages view or the deletion process will be interrupted and will not completely delete all the messages.

Expected:
The user should see the "gray deleting" screen when they wake the phone back up during the deletion process and not see any overlapping text. Also, the messages and date message headers are completed deleted without issue.

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20131126004001
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/21e2ad082d85
Gaia: 264c6044b941437ac3c4b28fe4ca392d2bc78445
Platform Version: 26.0
RIL Version: 01.02.00.019.102 

Notes:
Repro frequency: 100%
See attached: video, logcat
Attached image Overlapping text
We are working on getting the script to add large amounts of messages working on the Leo v 1.1.0 for regressions.
QA Wanted to see if this reproduces on 1.1.
Keywords: perf, qawanted
There is a building block issue (similar than in the other overlapping issues) that makes this more apparent. Adding a background-color should help.

That said, it looks like we lose the background-image (and maybe this is why the other issues were made more apparent too?).
Flags: needinfo?(vittone)
This issue partly reproduce on Leo v 1.1.0 COM RIL

Environmental Variables
Device: Leo v 1.1.0 COM RIL
Build ID: 20131205041342
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/05117f42088f
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
RIL Version: 01.01.00.019.281 

The user will see a blank white screen for a few seconds after waking up the device and an old date message header will be left behind after the device has finished deleting all the messages. However, the overlapping text does not occur.
Keywords: qawanted
Assignee: nobody → arnau
Attached file patch in github
Julien, Jose is proposing this radial background instead of the background image we have, I don't know how expensive a radial background is. Could you please let us know? An alternative solution could be a linear background (if faster) and as a last option a plain color + alpha: rgba(59,59,59,0.9).

Thanks!
Attachment #8344621 - Flags: review?(felash)
I think Arnau clears my needinfo, please ask me if something comes up.
Flags: needinfo?(vittone)
Comment on attachment 8344621 [details]
patch in github

Hey Arnau,

actually I don't know if this is expensive or not. The best way is to try it yourself on the device ;)

Also, you don't need to use "-moz-radial-gradient", just use "radial-gradient".
Attachment #8344621 - Flags: review?(felash)
Before I try to test performance, it would be good to know if that patch solves this bug. Could you please try to reproduce it using this patch?
Flags: needinfo?(ktucker)
I don't know for the issue in comment 0 but I do see improvements in the various menus: we don't see a transparent background anymore at the first load.

However, I notice a slightly longer delay when showing the action menu. This is maybe only in my head though ;)
Thanks Julien, I'll then try to get some figures for:
-radial gradient
-lineal gradient
-plain color

And discuss the results with the VD team to take a decision.
We tried testing this issue with patch but could not get the messaging app to function properly. Messages never loaded on the device and the compose new message and delete button were not functioning.
Flags: needinfo?(ktucker)
(In reply to ktucker from comment #13)
> We tried testing this issue with patch but could not get the messaging app
> to function properly. Messages never loaded on the device and the compose
> new message and delete button were not functioning.

Just curious, were you using reference workloads? I recently experienced a similar issue when using reference workload light
The reference workloads are converted correctly but it takes some time (especially in the Contacts DB). So for the big workloads it's really long.
Julien, is this still an issue?  Should we just add a wake lock?
Flags: needinfo?(felash)
Priority: -- → P2
Whiteboard: dogfood1.2 → dogfood1.2[c= u=p= s=]
Ben, I don't know if this still happens, this would need to be tested again.

And I don't know if it's a cpu or a memory issue.
Flags: needinfo?(felash)
QA, can you check to see if this happens in 1.3?
Keywords: qawanted
This issue does not occur in today's 1.3. The messages are deleted appropriately, and no unexpected text is visible in the app or homescreen.

Environmental Variables
Device: Buri v1.2 Moz RIL
Build ID: 20140212004003
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ab07e61c2eb0
Gaia: ce17d5eae7b1893ae4397c814b10ae598fcbdb58
Firmware Version: v1.2-device.cfg
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: