946525 - ./mach build binaries doesn't pick up changes to toolkit/components/telemetry/Histograms.json

Status: REOPENED

(Firefox Build System :: General, defect)

Description

[Andrew McCreight [:mccr8]]

I added a telemetry probe to Histograms.json, and a use of it in dom/base/nsJSEnvironment.cpp, then did ./mach build binaries, and it looks like it didn't rebuild whatever telemetry thing is needed:

 0:02.05 nsJSEnvironment.o
 0:03.28 /Users/amccreight/mc/dom/base/nsJSEnvironment.cpp:2214:36: error: no member named 'CYCLE_COLLECTOR_MAX_PAUSE' in namespace 'mozilla::Telemetry'; did you mean 'CYCLE_COLLECTOR_FULL'?
 0:03.28   Telemetry::Accumulate(Telemetry::CYCLE_COLLECTOR_MAX_PAUSE, gCCStats.mMaxSliceTime);
 0:03.28                         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
 0:03.28                                    CYCLE_COLLECTOR_FULL
 0:03.28 ../../dist/include/mozilla/TelemetryHistogramEnums.h:15:3: note: 'CYCLE_COLLECTOR_FULL' declared here
 0:03.28   CYCLE_COLLECTOR_FULL,
 0:03.28   ^
 0:03.28 1 error generated.

Running "./mach build" did rebuild things correctly.

Comment 1

[Nicholas Nethercote [inactive]]

Isn't that expected?  You changed something other than a .cpp or .h file...

Comment 2

[Mike Hommey [:glandium]]

Indeed, currently, this is a "feature". Don't forget mach build binaries is a temporary shortcut to have fast builds when you make changes to headers or source files. Not IDL, not JS, not webidl, etc.

The end goal is to have all those build improvements part of the normal build.

Comment 3

[Mike Hommey [:glandium]]

Come to think of it, this is something that should actually be fixed.