Closed
Bug 946555
Opened 11 years ago
Closed 11 years ago
[Bluetooth][cleanup] Remove unused functions in BluetoothService classes and some warnings
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ben.tian, Assigned: ben.tian)
Details
Attachments
(1 file, 1 obsolete file)
|
27.55 KB,
patch
|
echou
:
review+
|
Details | Diff | Splinter Review |
Remove unused functions and some warnings.
|
Assignee | |
Comment 1•11 years ago
|
||
Changes: - remove unused functions in BluetoothService classes - revise ConnectSco function in bluez HFP manager - remove some warnings.
Assignee: nobody → btian
Attachment #8342834 -
Flags: review?(echou)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Remove some bluez and debug build warnings.
Attachment #8342834 -
Attachment is obsolete: true
Attachment #8342834 -
Flags: review?(echou)
Attachment #8343524 -
Flags: review?(echou)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8343524 [details] [diff] [review] [final] Patch 1: remove unused functions and some warnings, r=echou Review of attachment 8343524 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thanks for cleaning this up.
Attachment #8343524 -
Flags: review?(echou) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8343524 -
Attachment description: Patch 1 (v2): remove unused functions and some warnings → [final] Patch 1: remove unused functions and some warnings, r=echou
|
|
Assignee | |
Comment 4•11 years ago
|
||
try server: https://tbpl.mozilla.org/?tree=Try&rev=bdc63f4f1022
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/b51aded2e621
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b51aded2e621
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•11 years ago
|
||
Nominate for 1.3 as the cleanup patch does no harm and would save many rebase efforts for future uplifts.
blocking-b2g: --- → 1.3?
|
||
Comment 8•11 years ago
|
||
triage: not blocking 1.3 but per comment 7 this will save efforts in future 1.3+ merges. please ask for approval
blocking-b2g: 1.3? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•