Closed Bug 946557 Opened 7 years ago Closed 7 years ago

B2G RIL: Bring test_icc_info.js back in automation

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.3 Sprint 6 - 12/6

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

In bug 875721, the dom/network/tests/marionette/test_mobile_iccinfo.js was moved to dom/icc/tests/marionette/test_icc_info.js, but it wasn't added into the manifest. So this test hasn't been running in automation since.
Attached patch Patch, v1Splinter Review
Correct the manifest.
Attachment #8342852 - Flags: review?(allstars.chh)
Comment on attachment 8342852 [details] [diff] [review]
Patch, v1

Review of attachment 8342852 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/tests/marionette/manifest.ini
@@ +4,5 @@
>  qemu = true
>  
>  [test_mobile_networks.js]
>  disabled = Bug 808783
>  [test_mobile_voice_state.js]

I am surprised Marionette doesn't report error if the test script is missing, could you file a bug for this?
Attachment #8342852 - Flags: review?(allstars.chh) → review+
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #3)
> Comment on attachment 8342852 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8342852 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/network/tests/marionette/manifest.ini
> @@ +4,5 @@
> >  qemu = true
> >  
> >  [test_mobile_networks.js]
> >  disabled = Bug 808783
> >  [test_mobile_voice_state.js]
> 
> I am surprised Marionette doesn't report error if the test script is
> missing, could you file a bug for this?

Sure, thanks.
https://hg.mozilla.org/mozilla-central/rev/8ec2e86bd691
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.