946590 - Share submenu crashes Fennec

Status: RESOLVED DUPLICATE of bug 945375

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

This line forces us to return null if the user clicks on a menu item that has an ActionProvider associated with it.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/GeckoMenuItem.java#145

Our action provider implementation works by generating the submenu when the item is clicked in this case:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/GeckoMenu.java#433

This causes it to always return null. i.e. it advertises it has a submenu and then doesn't return one, causing us to crash.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8342905 [details]
Patch

This reverts the change. Michael, since ram is out, I don't think anyone around right now really knows this code well. You mind looking it over?

Comment 2

[Lucas Rocha (:lucasr)]

Wes, I've fixed this (with the exact same patch) in bug 945375. This was a regression from bug 936756. Closing as dup.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8342905 [details]
Patch

Clearing r? since the bug's been closed.