946614 - [Email] Div Lines too dark

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Eric Pang [:epang] UX]

Attachment: email.png

Hey Pavel,

The div lines looks way too dark.  Can you help update them to be the same as the ones in the contact app?

Thanks!

Comment 1

[Joshua Smith [:joshua-s]]

I hope it was okay to take this.

Comment 2

[Joshua Smith [:joshua-s]]

FYI, the border for list items in the contacts app is border-bottom: 0.1rem solid #E7E7E7.

Comment 3

[Joshua Smith [:joshua-s]]

Hmm, looks like this is a deeper issue: the email app does not use the list BB.  Eric, do you want me to address that, or does email not use it for a reason?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Joshua Smith [:joshua-s] from comment #3)
> Hmm, looks like this is a deeper issue: the email app does not use the list
> BB.  Eric, do you want me to address that, or does email not use it for a
> reason?

Just change .msg-header-details-section at
https://github.com/mozilla-b2g/gaia/blob/master/apps/email/style/message_cards.css#L102

(I'm assuming this is desired for last minute 1.3 landing or uplift and more extensive changes to the e-mail app's list display could potentially cause FPS changes or other regressions that we don't want to get into at this stage of the game.)

Comment 5

[Joshua Smith [:joshua-s]]

Attachment: Patch for Gaia/master

Comment 6

[Joshua Smith [:joshua-s]]

Someone else will have to do the screenshot, I can't set up an email.  POP3 support ftw!

Comment 7

[Eric Pang [:epang] UX]

(In reply to Andrew Sutherland (:asuth) from comment #4)
> (In reply to Joshua Smith [:joshua-s] from comment #3)
> > Hmm, looks like this is a deeper issue: the email app does not use the list
> > BB.  Eric, do you want me to address that, or does email not use it for a
> > reason?
> 
> Just change .msg-header-details-section at
> https://github.com/mozilla-b2g/gaia/blob/master/apps/email/style/
> message_cards.css#L102
> 
> (I'm assuming this is desired for last minute 1.3 landing or uplift and more
> extensive changes to the e-mail app's list display could potentially cause
> FPS changes or other regressions that we don't want to get into at this
> stage of the game.)

Thanks Andrew, this is correct.  Thanks for the feedback :).

Joshua, thanks for working on this but next time please let someone know before you take a bug.  I'll review this now.

Comment 8

[Eric Pang [:epang] UX]

Comment on attachment 8343697 [details] [review]
Patch for Gaia/master

Visually this looks good to me, thanks Josuha.
Andrew can you help review and land?  Thanks in advance for your feedback and help!  Really want to get this fix into 1.3

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/14457
https://github.com/mozilla-b2g/gaia/commit/b6f526570c72680a4a9c5b6f4c99bece2acab1e9

(In reply to Eric Pang [:epang] from comment #8)
> Andrew can you help review and land?  Thanks in advance for your feedback
> and help!  Really want to get this fix into 1.3

I don't think we've branched gaia yet for 1.3, so this should have made it in.

Comment 10

[Eric Pang [:epang] UX]

(In reply to Andrew Sutherland (:asuth) from comment #9)
> landed in gaia/master:
> https://github.com/mozilla-b2g/gaia/pull/14457
> https://github.com/mozilla-b2g/gaia/commit/
> b6f526570c72680a4a9c5b6f4c99bece2acab1e9
> 
> (In reply to Eric Pang [:epang] from comment #8)
> > Andrew can you help review and land?  Thanks in advance for your feedback
> > and help!  Really want to get this fix into 1.3
> 
> I don't think we've branched gaia yet for 1.3, so this should have made it
> in.

finger's crossed, thanks Andrew :).