Closed
Bug 946614
Opened 11 years ago
Closed 11 years ago
[Email] Div Lines too dark
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: joshua-s)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files)
Hey Pavel, The div lines looks way too dark. Can you help update them to be the same as the ones in the contact app? Thanks!
Assignee | ||
Comment 2•11 years ago
|
||
FYI, the border for list items in the contacts app is border-bottom: 0.1rem solid #E7E7E7.
Assignee | ||
Comment 3•11 years ago
|
||
Hmm, looks like this is a deeper issue: the email app does not use the list BB. Eric, do you want me to address that, or does email not use it for a reason?
Flags: needinfo?(epang)
Assignee | ||
Updated•11 years ago
|
Hardware: x86 → Other
Comment 4•11 years ago
|
||
(In reply to Joshua Smith [:joshua-s] from comment #3) > Hmm, looks like this is a deeper issue: the email app does not use the list > BB. Eric, do you want me to address that, or does email not use it for a > reason? Just change .msg-header-details-section at https://github.com/mozilla-b2g/gaia/blob/master/apps/email/style/message_cards.css#L102 (I'm assuming this is desired for last minute 1.3 landing or uplift and more extensive changes to the e-mail app's list display could potentially cause FPS changes or other regressions that we don't want to get into at this stage of the game.)
Flags: needinfo?(epang)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #8343697 -
Flags: review?
Assignee | ||
Comment 6•11 years ago
|
||
Someone else will have to do the screenshot, I can't set up an email. POP3 support ftw!
Reporter | ||
Comment 7•11 years ago
|
||
(In reply to Andrew Sutherland (:asuth) from comment #4) > (In reply to Joshua Smith [:joshua-s] from comment #3) > > Hmm, looks like this is a deeper issue: the email app does not use the list > > BB. Eric, do you want me to address that, or does email not use it for a > > reason? > > Just change .msg-header-details-section at > https://github.com/mozilla-b2g/gaia/blob/master/apps/email/style/ > message_cards.css#L102 > > (I'm assuming this is desired for last minute 1.3 landing or uplift and more > extensive changes to the e-mail app's list display could potentially cause > FPS changes or other regressions that we don't want to get into at this > stage of the game.) Thanks Andrew, this is correct. Thanks for the feedback :). Joshua, thanks for working on this but next time please let someone know before you take a bug. I'll review this now.
Reporter | ||
Comment 8•11 years ago
|
||
Comment on attachment 8343697 [details] [review] Patch for Gaia/master Visually this looks good to me, thanks Josuha. Andrew can you help review and land? Thanks in advance for your feedback and help! Really want to get this fix into 1.3
Attachment #8343697 -
Flags: review? → review?(bugmail)
Updated•11 years ago
|
Attachment #8343697 -
Flags: review?(bugmail) → review+
Comment 9•11 years ago
|
||
landed in gaia/master: https://github.com/mozilla-b2g/gaia/pull/14457 https://github.com/mozilla-b2g/gaia/commit/b6f526570c72680a4a9c5b6f4c99bece2acab1e9 (In reply to Eric Pang [:epang] from comment #8) > Andrew can you help review and land? Thanks in advance for your feedback > and help! Really want to get this fix into 1.3 I don't think we've branched gaia yet for 1.3, so this should have made it in.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•11 years ago
|
||
(In reply to Andrew Sutherland (:asuth) from comment #9) > landed in gaia/master: > https://github.com/mozilla-b2g/gaia/pull/14457 > https://github.com/mozilla-b2g/gaia/commit/ > b6f526570c72680a4a9c5b6f4c99bece2acab1e9 > > (In reply to Eric Pang [:epang] from comment #8) > > Andrew can you help review and land? Thanks in advance for your feedback > > and help! Really want to get this fix into 1.3 > > I don't think we've branched gaia yet for 1.3, so this should have made it > in. finger's crossed, thanks Andrew :).
You need to log in
before you can comment on or make changes to this bug.
Description
•