Closed Bug 946625 Opened 8 years ago Closed 7 years ago

[Settings - Email Settings] Toggles have incorrect right margin

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: epang, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken)

Attachments

(4 files)

Attached image email-2.png
In the email settings where there is more then 1 line of text in a list item the toggle's right margin is incorrect.

It should be a 1.5 rem right margin.
Attached image After patch screenshot
Attachment #8346205 - Flags: feedback?(epang)
Hey Eric,
this bug affects this screen too
Attachment #8346206 - Flags: feedback?(epang)
Comment on attachment 8346205 [details]
After patch screenshot

Looks good, thanks Pavel!
Attachment #8346205 - Flags: feedback?(epang) → feedback+
Comment on attachment 8346206 [details]
After patch screenshot - existing account

Looks good too, thanks!
Attachment #8346206 - Flags: feedback?(epang) → feedback+
Attached file patch for Gaia/master
Attachment #8347436 - Flags: review?(jrburke)
Comment on attachment 8347436 [details] [review]
patch for Gaia/master

Added a comment for consideration. Flip back to review after processing it.
Attachment #8347436 - Flags: review?(jrburke)
Blocks: SysFE
No longer blocks: 1.3-visual-refresh
Whiteboard: ux-tracking, visual design, visual-tracking, jian → ux-tracking, visual design, visual-tracking, bokken
(In reply to James Burke [:jrburke] from comment #6)
> Comment on attachment 8347436 [details] [review]
> patch for Gaia/master
> 
> Added a comment for consideration. Flip back to review after processing it.

Hey Pavel, have you had a chance to look into the feedback from James?
Flags: needinfo?(pivanov)
Comment on attachment 8347436 [details] [review]
patch for Gaia/master

Hey James,
thanks for comments :) I think now it's ok :)
Attachment #8347436 - Flags: review?(jrburke)
Flags: needinfo?(pivanov)
Attachment #8347436 - Flags: review?(jrburke) → review+
Thanks James :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/34688bb6e382027006b6dd9e3b07d5c05998d338
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Duplicate of this bug: 990766
You need to log in before you can comment on or make changes to this bug.