946625 - [Settings - Email Settings] Toggles have incorrect right margin

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Pang [:epang] UX]

Attachment: email-2.png

In the email settings where there is more then 1 line of text in a list item the toggle's right margin is incorrect.

It should be a 1.5 rem right margin.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot - existing account

Hey Eric,
this bug affects this screen too

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8346205 [details]
After patch screenshot

Looks good, thanks Pavel!

Comment 4

[Eric Pang [:epang] UX]

Comment on attachment 8346206 [details]
After patch screenshot - existing account

Looks good too, thanks!

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8347436 [details] [review]
patch for Gaia/master

Added a comment for consideration. Flip back to review after processing it.

Comment 7

[Eric Pang [:epang] UX]

(In reply to James Burke [:jrburke] from comment #6)
> Comment on attachment 8347436 [details] [review]
> patch for Gaia/master
> 
> Added a comment for consideration. Flip back to review after processing it.

Hey Pavel, have you had a chance to look into the feedback from James?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8347436 [details] [review]
patch for Gaia/master

Hey James,
thanks for comments :) I think now it's ok :)

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks James :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/34688bb6e382027006b6dd9e3b07d5c05998d338