946639 - enable AVX2 on Linux if supported (libvpx)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jan Gerber]

Current toolchain on build servers does not support AVX2. Once its supported Linux builds should use AVX2.

Comment 1

[Frank Wein [:mcsmurf]]

Looks like a valid bug to me, so confirming :)

Comment 2

[Ralph Giles (:rillian)]

According to glandium on irc, the issue is the binutils version on our build machines; gcc supports the instructions, but the assembler does not.

Comment 3

[Ralph Giles (:rillian)]

Attachment: Enable AVX2

Hmm. This patch actually passes try. Maybe this is a different issue from libyuv because libvpx uses intrinsics for this instead of inline assembly?

Comment 4

[Ralph Giles (:rillian)]

https://tbpl.mozilla.org/?tree=Try&rev=f0df35384977

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8360512 [details] [diff] [review]
Enable AVX2

Review of attachment 8360512 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if we can enable this on Windows too?

Comment 6

[Ralph Giles (:rillian)]

(In reply to Chris Pearce (:cpearce) from comment #5)

> I wonder if we can enable this on Windows too?

As soon as we move to VS2012. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/684a92697548

Comment 7

[Jan Gerber]

Attachment: 0001-Bug-946639-Dont-disable-avx2-for-linux-builds-in-upd.patch

While enabling it for builds, would be also good to remove the special case from update.py to disable it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/684a92697548