946653 - [Unagi_1.2][Pre-IOT] The lock bar is showed highlighted when cancelling the unblock code

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[David Palomino [:dpalomino]]

Attachment: lock_bar.png

This issue has been reported during pre-IOT 1.2. 

device: unagi
Gecko: d77ba08
Gaia: 1b67b55

STR: 
1. Block the DUT with a code
2. Lock the screen and short press the power buton
3. Press "Cancel", it will show the "lock bar" in the initial state
4. Move the "lock bar" to the right, to unlock the screen
5. Press "Cancel" again, DUT will show the "lock bar" highlighted 

Actual Result: 
DUT will show the "lock bar" highlighted (see attached file)

Expected Result: 
DUT should show the bar in the initial state

This is quite ugly issue for the user... In case it'd be something not risky to fix, could we think to include it for koi? Nominated for discussion.

Comment 1

[Preeti Raghunath(:Preeti)]

What is the reproducibility rate?

What device did we test on?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #1)
> What is the reproducibility rate?

The STR above from what I read sounds like 100% repro rate.

> 
> What device did we test on?

It's unagi. But the issue here sounds like it would reproduced on all devices, as the lockscreen issue here would be device independent.

Comment 3

[Preeti Raghunath(:Preeti)]

UX

Please chime in on:

Is it bad UX and can wait till 1.3?

OR Is it extremely bad that it has to be fixed in 1.2?

Comment 4

[Preeti Raghunath(:Preeti)]

Tim,

Please review for lock screen and reassign appropriately.

Not easily seen though.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

If you check the style first, you'll notice this is affected by statusbar.css:

44b7b559 (Vivien Nicolas              2013-04-30 17:49:54 +0200  25) #screen.locked:not(.attention) #statusbar{
44b7b559 (Vivien Nicolas              2013-04-30 17:49:54 +0200  26)   background-color: transparent;
44b7b559 (Vivien Nicolas              2013-04-30 17:49:54 +0200  27) }

I disable the background-color property on Nightly and it restores to black. However, this seems intentional to be transparent, and conflicts with the spec listed in Bug 887802, which shows a black statusbar while locked.

I would provide a patch for this by disable the CSS property soon.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

After review & approval, I would land this on v1.2, too.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8346980 [details] [review]
Patch

Oh, Tim remind me the meaing of 'lock bar' (slide) and the 'DUT'. I'll give a correct patch as soon as possible

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The STR is exactly equal to bug 939434 ... maybe that was not a exhaust fix or maybe something was wrong with the uplift.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

This bug is unable to reproduce on PVT build (v1.2)

Gaia      6d02039072a2ae5cf9225a6f4c78ed49decfab5c
Gecko     http://hg.mozilla.org/mozilla-central/rev/1ad9af3a2ab8
BuildID   20131212040203
Version   29.0a1

And even on the Gaia v1.2 I pull from GitHub directly

Gaia      1aca7c4860e39b1a9969807d335dcf9f070ea9b3

I think the reporter use an old version which is logged at:

commit 1b67b551be11daf33dad8387a7153cc52e5cefa2
Merge: 7dfab3a be4922f
Author: Trif Andrei-Alin <[e-mail]>
Date:   Wed Nov 27 06:39:39 2013 -0800

Can David check this again?

Comment 10

[Jason Smith [:jsmith]]

QA Wanted - Does this bug reproduce on the latest 1.2 gaia/gecko?

Comment 11

[Matthew Vaughan]

This issue does NOT reproduce for me on the 12/13 1.2 build.

Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131213004002
Gaia: 1aca7c4860e39b1a9969807d335dcf9f070ea9b3
Gecko: a2b69b561d9b
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: 20131115

Comment 12

[Jason Smith [:jsmith]]

Closing as wfm then - reopen if you end up still reproducing this on 1.2.

Comment 13

[David Palomino [:dpalomino]]

Hi, 

I've tested this with a newer version, and now it's working fine :)

Thanks!
David

Comment 14

[Stephany Wilkes]

Clearing ni? as this is Resolved.