Closed Bug 946660 Opened 6 years ago Closed 6 years ago

[Download Manager] Downloading notifications shouldn't be displayed in the toaster

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.3 Sprint 6 - 12/6

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

The toaster should show when a download is started, failed or complete
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1
Thanks
Attachment #8343020 - Flags: review?(felash)
Comment on attachment 8343020 [details]
Patch v1

looks good to me
r=me with nits, and please answer the question about the location of the updateToaster call.

Also, please merge with a green travis if possible
Attachment #8343020 - Flags: review?(felash) → review+
(In reply to Julien Wajsberg [:julienw] from comment #2)
> Comment on attachment 8343020 [details]
> Patch v1
> 
> looks good to me
> r=me with nits, and please answer the question about the location of the
> updateToaster call.

Done

> 
> Also, please merge with a green travis if possible

As usual ;) I have all the day to do that Julien

Thanks a lot
https://github.com/mozilla-b2g/gaia/commit/0e4180ce239b4dd9b49f2e479c5336747eda8799
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 1.3 Sprint 6 - 12/6
You need to log in before you can comment on or make changes to this bug.