Closed
Bug 946662
Opened 11 years ago
Closed 11 years ago
Add MOZ_FINAL to MResumePoint
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jandem, Assigned: jandem)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
870 bytes,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
MResumePoint::setOperand sometimes shows up pretty high in profiles. It's mainly called from MResumePoint::inherit: we're using a slow virtual call there instead of inlining setOperand (at least with Clang 3.3). This patch marks MResumePoint as MOZ_FINAL, so that the compiler knows there are no subclasses (that can override setOperand), and it can safely inline the virtual MResumePoint::setOperand. Bug 891087 did this for MPhi and some other instructions.
Attachment #8343016 -
Flags: review?(hv1989)
|
||
Updated•11 years ago
|
Attachment #8343016 -
Flags: review?(hv1989) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c923a7e0c5ad
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c923a7e0c5ad
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•