946730 - [Dialer][Conference call] Ending a conference call message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Attachment: Ending a multi-call

12/05 master build:
Gecko-c37a72b
Gaia-6a20f5a

STR
Make a call
Make another call and merge them
Tap on red key to end the multi-call

EXPECTED
According to the WFs:https://mozilla.app.box.com/s/0u4jt353ei9ov2c150ip/1/1260971310/11291955740/1 pag 10 screen 2. When ending a multi-call only the 'End call' message is shown

ACTUAL
In addition to the expected 'End call' message it appears 'xxxxxx has left the call'. Where xxx is the last number called.
Please see screenshot attached.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The message is shown because we actually hang each call separately to end conference call. So we may need additional check to recognize "End the whole conference call" and stop calls inside from bringing up endcall message.

I think in the following case we should show 'xxxxx has left the call' for sure:
1. A remote call hangs up by itself.
2. We hangup a call in detail screen.

But I'm not sure about the following case:
* One call inside the two-call-conference call left, causing the conference call ended.
  (the last call inside also exits conference call, but still connected)

Comment 2

[isabelrios]

(In reply to KM Lee [:rexboy] from comment #1)
> The message is shown because we actually hang each call separately to end
> conference call. So we may need additional check to recognize "End the whole
> conference call" and stop calls inside from bringing up endcall message.
> 
> I think in the following case we should show 'xxxxx has left the call' for
> sure:
> 1. A remote call hangs up by itself.
> 2. We hangup a call in detail screen.
Yes, and this is how it is working now.

> But I'm not sure about the following case:
> * One call inside the two-call-conference call left, causing the conference
> call ended.
>   (the last call inside also exits conference call, but still connected)
Currently the device shows 'xxxx has left the call' and the other call continues normally as a single call. This seems to be working fine.

The case reported here is when the 'owner' of the multi-call hangs up the multi-call.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP
https://github.com/rexboy7/gaia/commit/92f6fd1a1fbf3a2d1570f1bf734211e89b16589a

Since there's no state for "Hanging up the whole conference call"
We have to log that "We are leaving the whole conference call" somewhere in Gaia.
See the WIP.
Not sure if it's a good solution but this is what I can come up for now.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

It's possible to remove HandledCall._leftGroup if we don't really care showing the "xxx left message" after disconnected status... (e.g. popup message right at ongroupchange event) But maybe there are some considerations for it so I'm leaving it as is.

Hello Etienne! May you help review this patch?

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8348593 [details]
patch

Oops, something wrong.... Let me check for a while. sorry for bothering.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8348593 [details]
patch

Should be OK now.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8348593 [details]
patch

Comments on github, glad to see we're removing workarounds :)

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8348593 [details]
patch

Thanks for the comments! updated based on them.
I think extracting _wasUnmerged is good. Also with a few minus changes.
May you take a look again?

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8348593 [details]
patch

r=me with the small unit test comment addressed.

Thanks!

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you Etienne!

Merged with small changes of Comment 10.
master
https://github.com/mozilla-b2g/gaia/commit/a49881df9a1ca48cea47e2e274cfa85a976e18bd

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted a49881df9a1ca48cea47e2e274cfa85a976e18bd to:
v1.3: be177663d2cefa1ee3f728be2e05d4905e576dc1

Comment 13

[isabelrios]

Verified on buri 01/15 v1.3 build:
Gecko-a08d78f
Gaia-14e199d