Closed Bug 946732 Opened 6 years ago Closed 6 years ago

xpcom/glue gtests are not built or run

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Since bug 844288 it seems that the tests in xpcom/glue/tests/gtests are not built or run.

Here is a patch to replace them.

I had to remove the unistd.h include from TestFileUtils.cpp to get this to compile on Windows, but it doesn't seem to affect anything.

Green try run is here: https://tbpl.mozilla.org/?tree=Try&rev=28604665267d
Attachment #8343085 - Flags: review?(bgirard)
Blocks: 942928
Attachment #8343085 - Flags: review?(bgirard) → review+
Blocks: 939206
No longer blocks: 942928
https://hg.mozilla.org/mozilla-central/rev/bd7e1da4923a
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.