Closed Bug 946747 Opened 11 years ago Closed 9 years ago

Fix the gaia-ui-endurance contacts tests

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: rwood)

Details

Attachments

(1 file)

Link to gaia pull request
47 bytes, text/x-github-pull-request
davehunt
: review+
Details | Review 
Fix the gaia-ui contacts endurance tests - they fail on one test box with a concatenation error but pass on the other.

test_endurance_add_contact
test_endurance_add_delete_contact
and test_endurance_add_edit_contact

        Attachment #8343297 -
        Flags: review?(dave.hunt)

    
    

    
  
Comment on attachment 8343297 [details] [review]
Link to gaia pull request

A few questions and nits, see pull request.

        Attachment #8343297 -
        Flags: review?(dave.hunt) → review-

    
    

    
  
Comment on attachment 8343297 [details] [review]
Link to gaia pull request

Thanks Dave, pull request updated.

        Attachment #8343297 -
        Flags: review- → review?(dave.hunt)

    
    

    
  
Comment on attachment 8343297 [details] [review]
Link to gaia pull request

Just one issue regarding using a consistent method to retrieve values from the mock contact.

        Attachment #8343297 -
        Flags: review?(dave.hunt) → review-

    
    

    
  
Comment on attachment 8343297 [details] [review]
Link to gaia pull request

Thanks Dave! Updated pull request, I got it right this time I promise :)

        Attachment #8343297 -
        Flags: review- → review?(dave.hunt)

    
    

    
  
Comment on attachment 8343297 [details] [review]
Link to gaia pull request

This looks fine. Just a couple of comments about string concatenation but not essential for this patch. r=me with or without the suggested changes.

        Attachment #8343297 -
        Flags: review?(dave.hunt) → review+

    
    

    
  
Thanks Dave. Merged PR into gaia master.

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: