Closed Bug 946775 Opened 6 years ago Closed 6 years ago

[contacts][facebook] When importing contacts, blue facebook header has wrong tapped color and close icon

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

RESOLVED FIXED
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: vittone, Assigned: arnau)

Details

Attachments

(3 files)

Attached image facebook-header-bug.png
No description provided.
Flags: needinfo?(kyee)
We will need to override the standard building block colors for this case.
Flags: needinfo?(kyee)
Assignee: nobody → arnau
Attached image after patch
Using #334d84 as pressed state color. That's a 13% + black overlay over facebook blue (aprox. the same increase used in default headers).
Attachment #8344557 - Flags: ui-review?(vittone)
Comment on attachment 8344557 [details]
after patch

I think this solves the issue. Thanks Arnau!
Attachment #8344557 - Flags: ui-review?(vittone) → ui-review+
Attached file patch in github
Casey, I have used the same close icons for the visual refresh, but in white.
The thing is that pressed area is not centered to 30px, so I've moved the icon -0.2rem.
I have seen in edit mode you had the same issue and you have a larger pressed area.
Could you please check with VD which should be the right approach?
Thanks
Attachment #8344561 - Flags: review?(kyee)
Attachment #8344561 - Flags: review?(kyee) → review?(jmcf)
It works perfectly, though I left a comment on GH for your consideration

thanks!
Comment on attachment 8344561 [details]
patch in github

thanks Arnau
Attachment #8344561 - Flags: review?(jmcf) → review+
blocking-b2g: --- → 1.3?
Merged: 1224458b1ae7671cba7df000f295a771a62966db
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
triage: 1.3+ for wrong color UI
blocking-b2g: 1.3? → 1.3+
Uplifted 1224458b1ae7671cba7df000f295a771a62966db to:
v1.3: dd9c71cd5f1dad9c2d941a0f0a5683d9914d35f3
You need to log in before you can comment on or make changes to this bug.