Closed
Bug 946779
Opened 11 years ago
Closed 11 years ago
Disable history in the hidden reader <browser> element
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: mfinkle, Unassigned)
Details
Attachments
(1 file)
1.10 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Just for completeness. We do not want to use global history when loading content into the hidden Reader <browser> since this adds delays and writes the visit to the global database. Firefox desktop uses the same flag for the Social <browser> and the background FrameWorker <browser>.
Attachment #8343147 -
Flags: review?(lucasr.at.mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 8343147 [details] [diff] [review] disableglobalhistory-reader Review of attachment 8343147 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8343147 -
Flags: review?(lucasr.at.mozilla) → review+
Reporter | ||
Comment 2•11 years ago
|
||
I found that we can be even more restrictive and disable all history (session and global) since we never intend to support back/forward history in this <browser>. Changed patch to "disablehistory" and Lucas r+ on IRC https://hg.mozilla.org/integration/fx-team/rev/2ae327cecde6
Summary: Disable global history in the hidden reader <browser> element → Disable history in the hidden reader <browser> element
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ae327cecde6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•