[B2G][Camera] After user opens new photo from thumbnail in camera app, zooming in, then out again causes photo to disappear

RESOLVED FIXED

Status

Firefox OS
Gaia::Gallery
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Brogan Zumwalt [Inactive], Assigned: johnhu)

Tracking

({regression})

unspecified
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed, b2g-v1.3 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Description:
When user takes picture in camera app then clicks on thumbnail preview at top of screen, zooming in, then back out of new image causes image to disappear. When picture is reopened from thumbnail in camera app the image is incorrectly scaled. This scaling issue also affects images taken after this issue occurs.

Repro Steps:
1) Updated Buri to Build ID: 20131205004003
2) Open Camera app
3) Press camera icon to take picture
4) Select new thumbnail of picture in upper left hand corner
5) Double tap to zoom in on picture
6) Double tap again to attempt to zoom out

Actual:
Zooming in, then out on a new picture causes picture to disappear.

Expected:
User can zoom in and out of a picture without incident.

Environmental Variables
Device: Buri v 1.2 COM RIL
Build ID: 20131205004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/af2c7ebb5967
Gaia: 0659f16b9790b1cf9eba4d80743fcc774d2ffe3a
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_US_20131115


Notes:
Repro frequency: 3/3, 100%
See attached: video clip - http://youtu.be/zW8q-bN0L3U
I also notice this behavior at gallery app. After doing some survey, I found [1] overrides the transform-origin to center, center, but not in [2] since newimage becomes this.image. And we need to remove transform-origin: 0, 0 from filmstrip.css and confirm.css.

[1] https://github.com/mozilla-b2g/gaia/blob/445cbc90e986d0d47194216eabd89a24f4a0f671/shared/js/media/media_frame.js#L35
[2] https://github.com/mozilla-b2g/gaia/blob/445cbc90e986d0d47194216eabd89a24f4a0f671/shared/js/media/media_frame.js#L177
Assignee: nobody → johu
Created attachment 8343496 [details] [review]
remove transform-origin: 0, 0 and put center, center back to newimage.

1. Remove transform-origin: 0, 0 from filmstrip.css and confirm.css
2. Put the style of transform-style back when newimage becomes this.image.
Attachment #8343496 - Flags: review?(dflanagan)
Does this reproduce on 1.1?
Keywords: qawanted

Updated

4 years ago
QA Contact: jschmitt

Comment 4

4 years ago
Does not reproduce in Buri 1.1, The picture does not disappear when zooming in and out.

Environmental Variables:
Device: (example: Buri v1.2 Mozilla RIL)
BuildID: 20131206041202
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: 05117f42088f
Version: 18.0
RIL Version: 01.01.00.019.281
Firmware Version: v1.2_20131115
Keywords: qawanted

Comment 5

4 years ago
Correct Environmental Variables for 1.1

Environmental Variables:
Device: Buri v1.1 COM RIL
BuildID: 20131206041202
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: 05117f42088f
Version: 18.0
RIL Version: 01.01.00.019.281
Firmware Version: v1.2_20131115

Updated

4 years ago
blocking-b2g: --- → koi?
Component: Gaia::Camera → Gaia::Gallery
Keywords: regression, regressionwindow-wanted

Updated

4 years ago
Keywords: regressionwindow-wanted
Comment on attachment 8343496 [details] [review]
remove transform-origin: 0, 0 and put center, center back to newimage.

r+

This bug is fallout from Tom's patch to support images with EXIF rotation. I'm embarassed that we did not catch it before now.

This fix is trivial and solves a serious bug. I strongly support making it koi+ and uplifting it to the v1.2 branch.
Attachment #8343496 - Flags: review?(dflanagan) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/06386175236ae1618663163849343172668dbdec


The travis failed are caused by other apps not related to this patch:
1. lockscreen: manipulate bluetooth settings "before each" hook
2. lockscreen: search "before each" hook
3. email: share url from browser share button should put url in email body
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
I'm going to uplift this myself now, so I can see if it also fixes 949254. I think that bug is just a dupe of this one.
Uplifted to v1.2: https://github.com/mozilla-b2g/gaia/commit/832e742379fd23343d15e6054cf7bdcdeaaeecdc

Marking this fixed for v1.2.  I don't know what to do about the v1.2f branch, however.
status-b2g-v1.2: affected → fixed

Updated

4 years ago
Duplicate of this bug: 949254
I've double-checked that this patch landed on master before the v1.3 branch was cut. 

jhford says that uplift to 1.2f is not needed here and that whoever is managing that branch will handle uplifts.  

So I think we're done.
status-b2g-v1.3: --- → fixed
You need to log in before you can comment on or make changes to this bug.