946807 - In the browser app, an activity without a "returnValue" should not call "postResult" or "postError"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Etienne Segonzac (:etienne)]

Hey we fixed it for the dialer.
But the same thing happens if you click a link in a sms message to open the browser.

+++ This bug was initially created as a clone of Bug #944468 +++

STR:
1. Send an SMS to the phone
2. Open messages app/wait for SMS
3. Open message thread
4. Tap header (where phone number is)
5. Select 'call' from activities menu
6. Dialer menu will open
7. Wait two seconds and the Messages app will slide back in.

Device:   Hamachi
Gaia:     0d57ec2801ae125ec855a19cf956ab118660d694
Gecko:    http://hg.mozilla.org/mozilla-central/rev/a5e7f611546f
BuildID   20131128040201
Version   28.0a1
ro.build.version.incremental=eng.archermind.20131114.105818


The regression range is within the last 24hrs of nightly build (27th Nov was a passing build in the Hamachi ui test automation).

Comment 1

[Jason Smith [:jsmith]]

Sounds like this is a blocker for the same reasons as bug 944468.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

The term is misleading.
'Activity without returnValue specified in manifest should not postResult/postError'

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14591

Comment 5

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/a14c8ba9fa829cdfa746bda2b88df642daee025a

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8346282 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14591

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ben, can you comment on the risk please?  It seems like we would need this for 1.3 as it's affecting 1.3 as well.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #9)
> Ben, can you comment on the risk please?  It seems like we would need this
> for 1.3 as it's affecting 1.3 as well.

This doesn't need a risk evaluation - this is a 1.3 blocker, so this does not need approval.

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8346282 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14591

No need for approval, it's 1.3+ already ;)

Comment 12

[Julien Wajsberg [:julienw]]

Should eventually be uplifted "automatically".
Also AFAIK Ben is in PTO, so if there are conflicts please NI Dale Harvey instead (the conflicts should be easy to resolve here).

Comment 16

[Jason Smith [:jsmith]]

John - Can you uplift this to 1.3?

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.3 ff5f06d] Merge pull request #14591 from daleharvey/946807