parsingcodemirror is missing a code path for mixed content errors from CSS rather than HTML

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: pomax, Assigned: pomax)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This causes the code to try to find a cursor position based on an openTag, which doesn't exist because CSS doesn't use tags.
(Assignee)

Comment 1

4 years ago
Created attachment 8343233 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/315

test locally on HTTP:// by setting the slowparse.js "checkMixedContent" variable to just "true" instead of its real check, then locally publishing the code from https://thimble.webmaker.org/project/1294/remix and remixing your local copy.
Attachment #8343233 - Flags: review?(jon)
(Assignee)

Comment 2

4 years ago
(also: if r+, feel free to land and push without me)

Updated

4 years ago
Attachment #8343233 - Flags: review?(jon) → review+

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.