946872 - Upgrade to puppet-3.4.2 / Facter-1.7.5

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This upgrade should also include the fix for http://projects.puppetlabs.com/issues/22107 on Mavericks, meaning custom-built DMGs.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

The custom-built DMG should also contain the patch for the recent ruby vulns, whatever they may be when I get around to this (collect them all!!)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

The combination of Puppet-3.4.2 and Facter-1.7.5 should be mavericky-compatible (but needs testing!)

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

I'll find a way to test this out in relabs, once we have more of the relabs systems up and running.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

OK, this is running in my environment in relabs.  I'll need to spin up some OS X and Ubuntu systems to check those out, then I can ship it.

File syncing from moco to relabs is disabled temporarily.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Hm, those minis seem to have corrupt filesystems..

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Works fine on Mountain Lion.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

The upgrade was a little rocky on Mavericks - some ruby errors about modules not existing.  I assume those are from require's that occur after the upgrade of puppet, and thus don't find the right source code.  That run of puppet failed, but the next one succeeded.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

..and verified on Ubuntu as well.

I think we're ready to go here!  We can do one operating system at a time, starting with CentOS (so the masters get updated).

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug946872.patch

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Oh, I'll only bump the yum repoflag; ignore the other hunk.

Comment 13

[Justin Wood (:Callek)]

Comment on attachment 8386175 [details] [diff] [review]
bug946872.patch

Review of attachment 8386175 [details] [diff] [review]:
-----------------------------------------------------------------

r+ without the deb repoflag change as discussed

::: modules/packages/manifests/puppet.pp
@@ +15,5 @@
> +    $old_facter_version = "1.7.1"
> +    $new_facter_version = "1.7.5"
> +    $facter_dmg_version = "${old_facter_version}"
> +    $facter_rpm_version = "${new_facter_version}-1.el6"
> +    $facter_deb_version = "${old_facter_version}-1puppetlabs1"

nit: drop "new_" from these vars, not worth the confusion once we drop "old_"

If you have a compelling reason to leave as-is it's acceptable though

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

I'm going to keep new until they're all new, then drop it.

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

Notice: /Stage[main]/Packages::Puppet/Package[facter]/ensure: ensure changed '1.7.1-1.el6' to '1.7.5-1.el6'
Notice: /Stage[main]/Packages::Puppet/Package[puppet]/ensure: ensure changed '3.2.2-1.el6' to '3.4.2-1.el6'
Notice: Finished catalog run in 26.62 seconds

re-run works fine.

Things went a little less well on the puppet masters.  I think what happened is this: the upgrade of puppet caused an upgrade of puppet-server as well, but to the latest version in the repo (3.4.3).  The later attempt to "upgrade" puppet-server to 3.4.2 failed because by then it was a downgrade.  I manually ran 'yum downgrade' on the puppet masters (along with a manual 'service httpd restart') and this seemed to fix it.

I emailed the list.

Comment 16

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug946872-p1.patch

Comment 17

[Dustin J. Mitchell [:dustin] (he/him)]

Ubuntu repos are sync'd, ready to roll on Monday.

Comment 18

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8386842 [details] [diff] [review]
bug946872-p1.patch

[[e-mail] ~]# puppet --version
3.4.2

looks fine from here

Comment 19

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug946872-p2.patch

..and finally, OS X.

Comment 20

[Justin Wood (:Callek)]

Comment on attachment 8389291 [details] [diff] [review]
bug946872-p2.patch

Review of attachment 8389291 [details] [diff] [review]:
-----------------------------------------------------------------

feel free to deploy this today, just ping in #releng so I know

Comment 21

[Dustin J. Mitchell [:dustin] (he/him)]

I'm not seeing any errors, so I'm going to cautiously call this fixed.  Yay!

Comment 22

[Dustin J. Mitchell [:dustin] (he/him)]

Worth noting here: this facter upgrade is to the newest version, but it still doesn't get the ec2_* facts.