946874 - [DSDS][Dialer] Display receiving SIM on call screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

As a user, when I receive a phone call, I want to be informed on which SIM the call is received.

Acceptance Criteria

AC1: I want an easy to understand, on the receiving call screen, to show via which SIM the call is being received
AC2: If the device is locked and a call is received I want to see via which SIM the call is received

Comment 2

[José Vittone]

Attachment: DSDS.Call_Incoming.png

Visuals and visual specs related to DSDS.

Comment 3

[José Vittone]

Attachment: SPEC_DSDS.Dialer.incomming_call.png

Comment 4

[José Vittone]

Attachment: DSDS.Call_Outgoing.png

Comment 5

[José Vittone]

Attachment: DSDS.2nd_incoming_call.png

Comment 6

[José Vittone]

Attachment: DSDS.Dailer.png

Comment 7

[José Vittone]

Attachment: DSDS.Dailer_SIM-picker.png

Comment 8

[José Vittone]

Attachment: SPEC_DSDS.Dialer.2nd_incomming_call.png

Comment 9

[José Vittone]

Attachment: SPEC_DSDS.Dialer.png

Comment 10

[José Vittone]

Attachment: SPEC_DSDS.Dialer.sim_picker.png

Comment 11

[José Vittone]

Attachment: icon-long-tap-indicator.zip

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

features should not block release, remove blocking flag

Comment 13

[Al Tsai [:atsai]]

#11674

Comment 14

[Carrie Wang [New account: [e-mail]]]

Hi guys, 

According to bug 947180, Message owner found that if we use "SIM 1 - " as the SIM indication for notification, it will look like "SIM 1 - [phone]" for unknown sender, which looks quite weird. Hence, we decide to change it to "(SIM 1) [phone]" (use parentheses rather than dash). In this way, we shall fix Dialer's notification as well to make it consistent in notification centre. So, it will look like "(SIM 1) Missed call". 
I'll update this to my spec as a reference and upload it later.

Hi Anthony, 

I don't really know who's in charge of this feature. Hence, I assign it to you. :) 
Feel free to switch it to the right person. Thanks!!

Comment 15

[Carrie Wang [New account: [e-mail]]]

Attachment: [1.4 DSDS] Dialer v0.4.pdf

Hi, 

Just attached the revised spec here. Please refer to p.6-7.
Thanks!

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

ni? Etienne to see if Etienne will be able to work on this one

Comment 17

[Joe Cheng [:jcheng] (please needinfo)]

from a separate conversation, this is targeted to be done by end of Sprint 3

Comment 18

[Anthony Ricaud (:rik)]

(In reply to Carrie Wang [:carrie] from comment #14)
> Hi Anthony, 
> 
> I don't really know who's in charge of this feature. Hence, I assign it to
> you. :) 
> Feel free to switch it to the right person. Thanks!!
I've opened bug 979453 to track this because it's about notifications, not call screen (topic of this bug)

Comment 19

[Etienne Segonzac (:etienne)]

Talked with Rik, taking this one for this week.

Comment 20

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

Comment 21

[Anthony Ricaud (:rik)]

Comment on attachment 8389322 [details] [review]
Gaia PR

\o/

Comment 22

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/ea9e23abea5933656555d849b922c8da7530c90b

Comment 23

[Axel Hecht [:Pike]]

I'm wondering about

+## LOCALIZATION NOTE "via" will be hidden in some cases
+via-sim=<span>via</span> SIM{{ n }}


In which cases is it one or the other?

The reason for asking is that "through something" is a different grammatical context than "something", and might yield a different localization.

Also, technically, should the whitespace be inside or outside of the <span>?

Comment 24

[Etienne Segonzac (:etienne)]

(In reply to Axel Hecht [:Pike][pto til 14th] from comment #23)
> I'm wondering about
> 
> +## LOCALIZATION NOTE "via" will be hidden in some cases
> +via-sim=<span>via</span> SIM{{ n }}
> 
> 
> In which cases is it one or the other?

* |via SIM1| is displayed on the call screen when only 1 call is going on
* the call waiting UI only displays |SIM1|
* the incoming call screen while the phone is locked only displays |SIM1|

> Also, technically, should the whitespace be inside or outside of the <span>?

I guess it should be inside.
A small follow is probably in order :)

Comment 25

[Francesco Lodolo [:flod]]

(In reply to Etienne Segonzac (:etienne) from comment #24)
> * |via SIM1| is displayed on the call screen when only 1 call is going on
> * the call waiting UI only displays |SIM1|
> * the incoming call screen while the phone is locked only displays |SIM1|

I'm not sure having such a string is enough for some locales. Take for example Czech:
* Locked SIM card -> SIM karta uzamčena
* SIM {{n}} PIN -> PIN karty SIM {{n}}

Having two separate strings and swapping them at run-time ("via SIMx", "SIMx"), instead of hiding the span, should be safer.

Also: there are already strings that use "SIM x" instead of "SIMx" in the same .properties file.

Comment 26

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #25)
> Also: there are already strings that use "SIM x" instead of "SIMx" in the
> same .properties file.

Correction: in the whole Gaia there's currently only one string using SIMx (no space), and it's in SMS App
https://github.com/etiennesegonzac/gaia/blob/master/apps/sms/locales/sms.en-US.properties#L210

Comment 27

[Anthony Ricaud (:rik)]

We use "SIM x" in https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/locales/sim.en-US.properties.

We could probably group all SIM related sentences together.

Comment 28

[Francesco Lodolo [:flod]]

(In reply to Anthony Ricaud (:rik) from comment #27)
> We use "SIM x" in
> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/
> locales/sim.en-US.properties.

Exactly. Only one other app (SMS) is currently using "SIMx", and it's worth fixing if you need to change the strings.

Comment 29

[Etienne Segonzac (:etienne)]

Given all those comments, and taking into account that apparently UX and visual do not agree on weather there should be a space between SIM and the number, and that we might have a space on the button but not on the call screen.

What is the safest follow up we can do this close to string freeze? :)

Comment 30

[Axel Hecht [:Pike]]

Consistency is the easy answer on simx vs sim x.

I agree that we should split the via and the non-via strings into two. Probably also resolves the problem of where the space goes?

Comment 31

[Eric Chang [:ericcc] [:echang]]

Works fine with this
Gaia      d2651c13d6370d62bf833b31c7e2e5f054510136
Gecko     c8a17e25111585c0eebb829f8208190ea432c71e
BuildID   20140318053055
Version   30.0a1

Comment 32

[Johan Lorenzo [:jlorenzo]]

Clearing backlog as bug 1093589 was created (and fixed).