947015 - ConvolverNode does not respect changes to normalize after buffer is set

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[Karl Tomlinson (:karlt)]

Attachment: testcase

Expected: Both buttons should make the same sound as the response buffer is the identity impulse response.

Actual: the convolved oscillator is quieter.

Comment 1

[Paul Adenot (:padenot)]

The spec is heading in a direction where `normalized` is only read when the buffer is set, so buffers would only be normalized if `normalized` is `true` before setting the buffer. NI to myself so I read the test case, convert it into a proper test, etc.

Comment 2

[Maire Reavy [:mreavy]]

Paul, any updates on this from the spec?

Comment 3

[Paul Adenot (:padenot)]

Yes, buffers are only normalized when set, so we need to test this.

https://github.com/WebAudio/web-audio-api/issues/122

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 5

[Paul Adenot (:padenot)]

We're doing the right thing, per spec. The spec has changed to only take the normalization into account at the time the buffer is set, and it's what we do.