947124 - Build keyboard-helper in gaia to handle "send key" and other keyboard functions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Evan Tseng [:evanxd]]

Hi all,

We should have marionette-keyboard plugin to handle keyboard things.

After we have marionette-keyboard, we could write tests to deal with some app and keyboard app at same time very easily.

For example, we could do the below script to operate the keyboard app in browser app test.
```
test('Test the address bar', function() {
  // Click the address bar, then the keyboard app will show up.
  client.keyboard.input('http://mozilla.org');
  // Click go.
  // Assert some thing.
});
```

Comment 1

[Evan Tseng [:evanxd]]

After the discuss with Gary and Alive, the marionette-keyboard plugin is not good enough.

We could just build a keyboard-help to do those things in gaia.

Thanks for Gary and Alive.

Comment 2

[Evan Tseng [:evanxd]]

Hi Gary,

Cool!
We could start to work on marionette tests for Keyboard app.
If you need any help, please let me know. :)

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/14951/files

Hi Evan,
   Please help to review this patch in next year. 
   
   Merry X'mas And Happy new year!!! ;)

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8351340 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/14951/files

Hi Gary,

Sorry for the late reply.

There is a new rule for review process of marionette test:

Please make sure the `marionette_js_stable_check` action of the patch is passed on Travis
(https://travis-ci.org/mozilla-b2g/gaia/jobs/18937817), then you set r? for your patch.

As you know marionette test of settings app is higher priority than this, so we will review the settings test first.

Thanks.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We already have the following file in keyboard's marionette-js test,
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/test/marionette/lib/keyboard.js

I think we need to add other Keyboard app related functions here, like send keys, so modify the title.

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Reset Assignee

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug947124-_keyboard_library_sendKey > mozilla-b2g:master

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8590188 [details] [review]
[gaia] RudyLu:keyboard/Bug947124-_keyboard_library_sendKey > mozilla-b2g:master

Tried to run this for more than 10 times, and it seems stable enough.
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bed1131748481f027c2344aa2d84bcfa7a54875d
(Gij7)


Tim,

Could you please help review this?
Thanks.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Thanks for the review.

Mark to land it.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e392c2b52c63bab0468bf871dff4d273e70821ad