947215 - [Messages][Drafts] Do not try to match an existing thread when saving a threadless draft

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

The current code tries to match an existing thread when saving a threadless ("new message") draft, and saves a thread-bound draft instead if matched. I recall we discussed this in the past but I think this was subsequently removed.

So I think this piece of code should be removed.

Ayman, can you comment on this?

Comment 1

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #0)
> The current code tries to match an existing thread when saving a threadless
> ("new message") draft, and saves a thread-bound draft instead if matched. I
> recall we discussed this in the past but I think this was subsequently
> removed.
> 
> So I think this piece of code should be removed.
> 

Yes this piece of code should be removed. 

I deliberately did not specify this behaviour as we cannot edit the ‘to field’ in the message thread... and we cannot guarantee that the user has finished editing the 'to field' when the draft is saved. I thought I had been quite clear on that.

This code would also create a conflict in the scenario where a user has already got a ‘draft’ message saved within the message thread into which the message that is being composed in the new message composer will be saved as we can only save one draft per message thread.

Comment 2

[Evelyn Eastmond [:evhan55]]

(In reply to ayman maat :maat from comment #1)
> (In reply to Julien Wajsberg [:julienw] from comment #0)
> > The current code tries to match an existing thread when saving a threadless
> > ("new message") draft, and saves a thread-bound draft instead if matched. I
> > recall we discussed this in the past but I think this was subsequently
> > removed.
> > 
> > So I think this piece of code should be removed.
> > 
> 
> Yes this piece of code should be removed. 
> 
> I deliberately did not specify this behaviour as we cannot edit the ‘to
> field’ in the message thread... and we cannot guarantee that the user has
> finished editing the 'to field' when the draft is saved. I thought I had
> been quite clear on that.
> 
> This code would also create a conflict in the scenario where a user has
> already got a ‘draft’ message saved within the message thread into which the
> message that is being composed in the new message composer will be saved as
> we can only save one draft per message thread.

Okay, thank you Ayman and Julien!

Comment 3

[Rick Waldron [:rwaldron]]

r=rwaldron landed in v1.3-drafts

https://github.com/rwaldron/gaia/commit/9840cce92c328633c68cf5071cc71537d7db7a96

Comment 4

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/ab580a704a0c40a7d1974cafe2dcf196b2143b0f