Remove special case for about:config's form data collection

RESOLVED FIXED in Firefox 29

Status

()

Firefox
Session Restore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
From TextAndScrollData.updateFrame():

> if (topURL == "about:config") {
>   entry.formdata = {
>     id: { "textbox": content.top.document.getElementById("textbox").value },
>     xpath: {}
>   };
> }

This always bothered me.
(Assignee)

Comment 1

4 years ago
Created attachment 8343757 [details] [diff] [review]
0001-Bug-947216-Remove-special-case-for-about-config-s-fo.patch
Attachment #8343757 - Flags: review?(smacleod)
(Assignee)

Comment 2

4 years ago
BTW, this is covered by browser_393716.js.
Comment on attachment 8343757 [details] [diff] [review]
0001-Bug-947216-Remove-special-case-for-about-config-s-fo.patch

Review of attachment 8343757 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8343757 - Flags: review?(smacleod) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/b9836f876013
https://hg.mozilla.org/mozilla-central/rev/b9836f876013
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.