Closed Bug 947290 Opened 6 years ago Closed 5 years ago

Description and release notes display is broken if it includes a <ul> or <ol>

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P5, trivial)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2015-03-24

People

(Reporter: mat, Assigned: kngo)

References

Details

(Whiteboard: [ktlo])

When fireplace displays description and release notes, it uses:

<p class="description" itemprop="description">
  {{ this.description|translate(this)|nl2br }}
</p>

This cause 2 problems:
- The <p> cannot contain <ul> or <ol>, but the field we are displaying might
- The |nl2br inserts <br> inside lists as well, causing the bullets to be misaligned with the content

We need to change the <p> to something else (keeping padding/margin correct), and be smarter about nl2br (which is generally a good thing, just not in lists).

See also discussion in https://github.com/mozilla/fireplace/pull/326
Severity: normal → trivial
Priority: -- → P5
Assignee: nobody → delza
Assignee: delza → nobody
Blocks: 1135257
No longer blocks: 1135257
Blocks: 1135257
This was fixed in desktop UI. we now use a div for description.

But I made the indents prettier: 

https://github.com/mozilla/fireplace/commit/bd6c9c73d5c6d5178272c49089206e18d9815d7a
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-03-24
Verified as fixed in FF39(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/lJsQ5mzmPjo3
Closing bug.
Status: RESOLVED → VERIFIED
Whiteboard: [ktlo]
You need to log in before you can comment on or make changes to this bug.