Closed
Bug 947325
Opened 10 years ago
Closed 10 years ago
require libvpx 1.3.0 if using --with-system-libvpx
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: j, Unassigned)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
814 bytes,
patch
|
rillian
:
review+
ted
:
review+
|
Details | Diff | Splinter Review |
libvpx 1.3.0 is required now, pkg-config check should be updated.
Reporter | ||
Comment 1•10 years ago
|
||
Attachment #8343848 -
Flags: review?(giles)
Comment 2•10 years ago
|
||
Comment on attachment 8343848 [details] [diff] [review] libvpx-1.3.0_pkg-config.patch Review of attachment 8343848 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Another build peer one-liner for you, Ted.
Attachment #8343848 -
Flags: review?(ted)
Attachment #8343848 -
Flags: review?(giles)
Attachment #8343848 -
Flags: review+
Comment 3•10 years ago
|
||
Comment on attachment 8343848 [details] [diff] [review] libvpx-1.3.0_pkg-config.patch Review of attachment 8343848 [details] [diff] [review]: ----------------------------------------------------------------- FWIW I think build peers would be fine with module owner review on something this trivial in the future (just bumping a version number).
Attachment #8343848 -
Flags: review?(ted) → review+
Comment 4•10 years ago
|
||
Thanks! And noted. I wasn't clear where the lines were for build-peer review, so was erring on the side of caution. :) https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba23d5502e1
https://hg.mozilla.org/mozilla-central/rev/1ba23d5502e1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 6•10 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #4) > Thanks! And noted. I wasn't clear where the lines were for build-peer > review, so was erring on the side of caution. :) Note that you have better knowledge than build peers as to what version of the API your code requires ;)
Comment 7•10 years ago
|
||
Just a sidenote - it's nice to have correct version deps, but upstream libvpx 1.3.0 was tagged in git only 4 days ago, and there's no real release tarball yet for that version on http://code.google.com/p/webm/downloads/list :)
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•