947325 - require libvpx 1.3.0 if using --with-system-libvpx

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jan Gerber]

libvpx 1.3.0 is required now, pkg-config check should be updated.

Comment 1

[Jan Gerber]

Attachment: libvpx-1.3.0_pkg-config.patch

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8343848 [details] [diff] [review]
libvpx-1.3.0_pkg-config.patch

Review of attachment 8343848 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Another build peer one-liner for you, Ted.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8343848 [details] [diff] [review]
libvpx-1.3.0_pkg-config.patch

Review of attachment 8343848 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW I think build peers would be fine with module owner review on something this trivial in the future (just bumping a version number).

Comment 4

[Ralph Giles (:rillian)]

Thanks! And noted. I wasn't clear where the lines were for build-peer review, so was erring on the side of caution. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba23d5502e1

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1ba23d5502e1

Comment 6

[Mike Hommey [:glandium]]

(In reply to Ralph Giles (:rillian) from comment #4)
> Thanks! And noted. I wasn't clear where the lines were for build-peer
> review, so was erring on the side of caution. :)

Note that you have better knowledge than build peers as to what version of the API your code requires ;)

Comment 7

[Landry Breuil (:gaston)]

Just a sidenote - it's nice to have correct version deps, but upstream libvpx 1.3.0 was tagged in git only 4 days ago, and there's no real release tarball yet for that version on http://code.google.com/p/webm/downloads/list :)