947339 - [B2G][Settings][Lock Screen]Enter your Passcode appears as “Create a Passcode”

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Peter Bylenga [:PBylenga]]

Attachment: LockScreenChangePasscode.png

Description:
When user wants to change their passcode or to enter their passcode to deactivate Lock Screen, the Input label reads “Create a Passcode” even though the app is requesting the user to enter the current passcode.  This appears to have been caused by bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=929921

Repro Steps:
1) Updated Buri to Build ID: 20131205040201
2) Launch Settings App
3) Navigate to Lock Screen
4) Turn on Passcode lock and Create a Passcode
5) Tap Change Passcode and Observe Input box Label.
6) Go back and Tap deactivate Passcode Lock and Observe Input box Label.


Actual:
Both strings appear as “Create a Passcode”

Expected:
Both strings should reflect the request for the already created Passcode to be entered.

Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20131205040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/725c36b5de1a
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Platform Version: 28.0a1
Firmware Version: 20131115

Notes:
Repro frequency: 5/5, 100%
See attached: Screenshots

Comment 1

[Peter Bylenga [:PBylenga]]

Attachment: LockScreenDeactivatePasscode.png

Screenshot showing the label string on the Deactivate Passcode screen.

Comment 2

[Peter Bylenga [:PBylenga]]

This issue does not occur on v1.2

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131204004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/758f3fb32dda
Gaia: 8d762f3376318fd6be390432db750ae4904c9ab6
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: V1.2_20131115

Comment 3

[Jason Smith [:jsmith]]

This is misleading UX for anyone planning to use passcode lock.

Comment 4

[J Zimbrick]

Last Working Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131029040205
Gaia: 92c097fd7ac9886f937d9decb0e03ab673deaa1b
Gecko: 518f5bff0ae4
Version: 28.0a1
Base Image: V1.2_20131115

First Broken Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131030040204
Gaia: 162cc9cd7153dcb284e5f54d5598fb27f1ab18aa
Gecko: 829d7bef8b0a
Version: 28.0a1
Base Image: V1.2_20131115

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression.

EJ, could you identify the regressed patch and fixed it?

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I will take a look at this bug, thanks Tim.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Hi Arthur, 

I made a small patch to reflect current mode onto UI to solve this bug. 

Please help me review when you have time, thanks !

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8345751 [details] [review]
patch on github

We have five different modes: edit, confirm, confirm-lock, new, and create. And each of them have different wording.

The bug was regressed by bug 929921 in which it should only change the wording for the mode "new". But it also changed the wording of the modes edit, confirm, and confirm-lock.

We need a new set of elements (<div class="passcode"> ... </div>) with a label "Passcode" in it for the modes "edit", "confirm" and "confirmLock". And use proper styles to control the visibility.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8345751 [details] [review]
patch on github

Hi Arthur, 

I just updated the code base on our off-line discussion. 

Please take a look when you have time, big thanks :P

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8345751 [details] [review]
patch on github

Good work, thanks!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, patches were landed on 

Gaia/master : f185fa84096b7fcac8b111233330f0765fc8941f
Gaia/v1.3 : 138a708a03276ff1c8b21f407f03ba34c4daf28a

:)

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

We saw a fairly large launch regression in settings for the time window where this landed (bug 951173).  Can you check to see if this commit caused the problem?

To test run:

  sudo pip install b2gperf
  adb forward tcp:2828 tcp:2828
  b2gperf --delay=10 Settings

And then look at the reported median value.  Thank you!

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Ben, I don't think this patch will cause the regression because this is a tiny patch for screen lock and will be triggered only when you get into that panel.

Here comes the perf report below :

With this patch ():

Results for Settings, cold_load_time: median:663, mean:675, std: 33, max:793, min:648, all:778,687,661,669,686,661,739,793,670,661,660,665,650,661,658,649,659,677,654,664,667,660,668,648,680,653,675,684,658,663

One commit before this patch (8a2b8d0e930aa16ec6d2271b336cfc0d531d05fa) :

Results for Settings, cold_load_time: median:661, mean:665, std: 22, max:776, min:648, all:776,667,652,661,684,660,648,670,676,655,654,661,654,679,651,649,651,674,671,666,656,670,656,656,667,655,650,668,680,662

Thanks.

Comment 15

[William Hsu [:whsu]]

Verified this patch.

* The tested build:
 - Gaia:     dca0a3dcf062ce3e422a9c56d141c14543c816fb
 - Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/1f7db4cc788e
 - BuildID   20131217004001
 - Version   28.0a2

Also, attaching the screenshot.

Comment 16

[William Hsu [:whsu]]

Attachment: 2013-12-18-17-28-56.png