Closed Bug 947350 Opened 10 years ago Closed 10 years ago

L10N string "removeCalendarsText" needs pluralization

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: JasnaPaka, Assigned: Fallen)

Details

Attachments

(1 file)

http://hg.mozilla.org/comm-central/file/default/calendar/locales/en-US/chrome/calendar/calendar-event-dialog.properties

L10N key "removeCalendarsText" needs pluralization. 

removeCalendarsText=Do you really want to remove %1$S attachments?

https://developer.mozilla.org/en-US/docs/Localization_and_Plurals
Attached patch Fix - v1Splinter Review
Thanks for the note, this should take care.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8344685 - Flags: review?(matthew.mecca)
Comment on attachment 8344685 [details] [diff] [review]
Fix - v1

It looks like the singular form won't currently be used since we only prompt with multiple items, maybe with this change it makes sense to prompt for confirmation on single attachment removal also?

Also, removeAttachmentsText might be a better name if we have to rename it anyway.
Attachment #8344685 - Flags: review?(matthew.mecca) → review+
(In reply to Matthew Mecca [:mmecca] from comment #2)
> Comment on attachment 8344685 [details] [diff] [review]
> Fix - v1
> 
> It looks like the singular form won't currently be used since we only prompt
> with multiple items, maybe with this change it makes sense to prompt for
> confirmation on single attachment removal also?
For English there are only two cases, but other locales have even more, i.e special cases for 3,5,10. I think we should stick with the current behavior, the goal was to avoid accidentally deleting a lot of attachments, but if you do this for one attachment its more likely you really did want to do so and an extra dialog would be annoying.

> 
> Also, removeAttachmentsText might be a better name if we have to rename it
> anyway.

Good idea, done.
Pushed to comm-central changeset b7a800c5a211
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.0
Target Milestone: 3.0 → 3.1
You need to log in before you can comment on or make changes to this bug.