947352 - [B2G][Contacts] Magnifying glass search icon on scroll list in contacts app does not function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Brogan Zumwalt [Inactive]]

Description:
In the Contacts app the magnifying glass search icon on the scrollbar to the right does not take user to search field when pressed. If user taps on this icon it highlights as if being pressed, but lacks any other functionality.

Repro Steps:
1) Updated Buri to Build ID: 20131206040203
2) Open Contacts app (with an existing list of contacts)
3) Press magnifying glass search icon on scrollbar


Actual:
Magnifying glass search icon in contacts app not functional.

Expected:
Tapping magnifying glass icon scrolls page up to search field.

Environmental Variables
Device: Buri v 1.3 Mozilla RIL
Build ID: 20131206040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/1401e4b394ad
Gaia: 8fca2ca67e8a6022fe6ed8cb576e5d59dfb5237f
Platform Version: 28.0a1
Firmware Version: V1.2_US_20131115


Notes:
Repro frequency: 3/3, 100%
See attached: video clip - http://www.youtube.com/watch?v=edgrnrBgU8U

Comment 1

[Marcia Knous [:marcia]]

I think we should probably attach a screenshot to this bug to show which icon you are talking about - I see what you mean - it is the tiny magnifying icon on the right hand side of the screen.

Comment 2

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot - Icon Location

Attached screenshot showing icon location.

Video is in URL & Comment 0

Comment 3

[Jason Smith [:jsmith]]

Does this reproduce on 1.1 & 1.2?

Comment 4

[Nikolai Khristoforov]

The bug reproduced on both 1.2 and 1.1. The Search button on the right does not function when the user presses it.

Device: Buri v1.2 Moz RIL
BuildID: 20131209004003
Gaia: f615ae7acb6731d191b3094e10e314bc28359bbb
Gecko: f684b8f159a3
Version: 26.0

Device: Leo v1.1 Moz RIL
BuildID: 20131203041431
Gaia: 19c9ff3a46a4389e40253c97b359763243af4531
Gecko: 617eb9d9bcc2
Version: 18.0

Comment 6

[Cristian Rodriguez (:crdlc)]

From my point of view we should scroll to search field (top of the list) because users are touching the alpha scroll instead of opening directly the search view. But I would like to know how it should work before Adrian starts implementing this bug. Carrie, any idea/suggestion? Thanks a lot for your support.

Comment 7

[Carrie Wang [New account: [e-mail]]]

Hi, 

To keep it consistent with the behavior of tapping the alphabet indicator, I'd suggest that if users tap the search icon, we scroll the page back to the top where the search field is located (and they can tap the search field to enter the search mode then). Thanks!

Comment 8

[Cristian Rodriguez (:crdlc)]

OK, thanks for your support. Understood

(In reply to Carrie Wang [:carrie] from comment #7)
> Hi, 
> 
> To keep it consistent with the behavior of tapping the alphabet indicator,
> I'd suggest that if users tap the search icon, we scroll the page back to
> the top where the search field is located (and they can tap the search field
> to enter the search mode then). Thanks!

Comment 9

[Adrián de la Rosa]

Attachment: 23553.html

After reading how the code works, I came up with this solution. It supposes that the search box will be always on top, but I think it's a fair supposition and I didn't want to make more changes to the code than necessary. Any way, if you think I should try to solve with other approach, please tell me.

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8482142 [details]
23553.html

LGTM although I would like a Fran's review too

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482142 [details]
23553.html

Tiny nit. Working perfect!

Comment 12

[Adrián de la Rosa]

Nit fixed, I will ask for merge when tbpl is done. Thanks!

Comment 13

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/f354078d45a1edeaa67a64f44c9403fc97f7bebc

Comment 15

[Loli (:lolimartinezcr)]

Tested in 2.2 and magnifying glass search icon in contacts app not functional.
Gecko-ca03f2d
Gaia-73a7ace

Comment 16

[Adrián de la Rosa]

What happened? I fixed it so when you use the scroller in the right side of the screen and you scroll to the magnifying glass, the view scrolls to top showing the search box. Tapping it does the same. I've just tested it with the last code from master and everything seems to be working fine.

Comment 17

[Cristian Rodriguez (:crdlc)]

Adrian, just in case check if your patch is already landed here https://github.com/mozilla-b2g/gaia/tree/v2.1

Comment 18

[Cristian Rodriguez (:crdlc)]

Although Loli says that it is not working on master (2.2). I honestly saw this working fine

Comment 19

[Loli (:lolimartinezcr)]

(In reply to Cristian Rodriguez (:crdlc) from comment #18)
> Although Loli says that it is not working on master (2.2). I honestly saw
> this working fine

Yesterday when I tested first time I thought the search should be open but I have 
spoken with M.Angeles and she has explained me.

I have retest and it is working,

2.1
Flame
Gecko-52f8689
Gaia-d61264c

Comment 20

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1
STR:
1. Open Contacts app (with an existing list of contacts).
2. Press magnifying glass search icon on scrollbar.
**It will back to search box field at top of page.
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Comment 22

[Sean Lee [:seanlee][:weilonge]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/add38992bbfb2bafca52ac1ce7f6231ac702675f

Comment 23

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on Flame v2.2 and woodduck 2.0.
See attachment: verified_v2.2.mp4.
Reproduce rate: 0/5

Flame 2.2 build:
Gaia-Rev        698e6e8a098cc060b26cd6f25171633c4c7e739d
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/57e4e9c33bef
Build-ID        20150103010205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150103.045144
FW-Date         Sat Jan  3 04:51:56 EST 2015
Bootloader      L1TC000118D0

Woodduck 2.0 build:
Gaia-Rev        3954e471652245293b5387e7bc732e52834658e5
Gecko-Rev       bb95bcf5c2033a59b3261b93804151d1addb75eb
Build-ID        20150104050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1420319384
FW-Date         Sun Jan  4 05:10:31 CST 2015

Comment 24

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.MP4