947406 - Package upload actor error when done

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The PackageUploadActor currently attempts to return an OS.File promise in response to the "done" message type, causing this error:

DBG-SERVER: error occurred while processing 'done: TypeError: aResponse is undefined
Stack: DSC_onPacket/response<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1038
resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
Handler.prototype.process@resource://gre/modules/Promise.jsm:767
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531

The error is harmless as everything installs fine.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Don't return promise when done with package upload

Try: https://tbpl.mozilla.org/?tree=Try&rev=a40e94cd0fcd

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8343951 [details] [diff] [review]
Don't return promise when done with package upload

Review of attachment 8343951 [details] [diff] [review]:
-----------------------------------------------------------------

Ooops... Thanks for covering my back ;)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/c1b0d554713f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1b0d554713f