94742 - header parsing regression

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Darin Fisher]

i've noticed on several occasions a failure to correctly parse the status line.
it appears that the status line is being treated as a response header in some
cases.  this may explain why some pages don't finish loading, etc.

Comment 1

[Darin Fisher]

Attachment: sample from about:cache demonstrating this problem

Comment 2

[Darin Fisher]

backed out this portion of bbaetz's fix for bug 89365:

    if (!mHaveStatusLine && mLineBuf.Last() == '\n') {
        // status lines aren't foldable, so don't try. See bug 89365
        ParseLine(NS_CONST_CAST(char*,mLineBuf.get()));
    }
and the problem went away.

Comment 3

[Darin Fisher]

Attachment: log file demonstrating the same problem on mozilla.org

Comment 4

[Darin Fisher]

Attachment: v1.0 fixed the problem

Comment 5

[Bradley Baetz (:bbaetz)]

r=bbaetz. oops.

Comment 6

[Darin Fisher]

my patch makes it so that we only check for a leading ' ' or '\t' if we already
have the status line.  in this way, we prevent allowing folded status lines as
was the point of bug 89365.

Comment 7

[Scott MacGregor]

sr=mscott

Comment 8

[Darin Fisher]

fixed-on-trunk

Comment 9

[Marek Z. Jeziorek]

[e-mail], has it beeen verified on the trunk? If yes, please change
the status summary and let's land on the 0.9.2 branch.

Comment 10

[Tom Everingham]

verified on trunk:

Win NT4 2001081303
Linux rh6 2001081308
Mac os9 2001081408

Comment 11

[Darin Fisher]

fixed-on-branch

Comment 12

[Tom Everingham]

verified