Closed
Bug 947432
Opened 11 years ago
Closed 11 years ago
[DSDS] Marketplace and Payment indication in Settings - SIM Manager app
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)
People
(Reporter: jcheng, Assigned: eragonj)
References
Details
Attachments
(3 files)
Per email discussion. In Settings -> SIM Manager, the strings describing "Data" is to be changed to "Data: Internet connection, MMS, A-GPS and Marketplace payments will be sent from"
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → arthur.chen
Summary: [DSDS] Marketplace and Payment indication on Settings - SIM Manager app → [DSDS] Marketplace and Payment indication in Settings - SIM Manager app
Comment 1•11 years ago
|
||
Hi Joe, Would you please help to triage this DSDS bug. Thank!
Flags: needinfo?(jcheng)
Reporter | ||
Comment 2•11 years ago
|
||
1.3+. this is the agreed upon scope with the marketplace team to only add a few strings
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(jcheng)
Assignee | ||
Updated•11 years ago
|
Assignee: arthur.chen → ejchen
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
for reference.
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8346422 [details] [review] patch on github Arthur, this is just a small UI fix. Please help me review the fix when you have free time (not so urgent). Thanks !!
Attachment #8346422 -
Flags: review?(arthur.chen)
Comment 6•11 years ago
|
||
Comment on attachment 8346422 [details] [review] patch on github r=me. Thanks!
Attachment #8346422 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 7•11 years ago
|
||
This patch was landed on Gaia/master : a71f70f131beb6139433ed72b679111da40c0291 Gaia/v1.3 : 589e780467b59324a107c41b0e69079e0f8c894e Thanks all :)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g-v1.3:
--- → fixed
Comment 8•11 years ago
|
||
I filed bug 950307 to rename this string, since it was changed without renaming the ID. Doubt about the last screenshot: is the repetition of "Data" really necessary/wanted?
Flags: needinfo?(firefoxos-ux-bugzilla)
Comment 9•11 years ago
|
||
I don't think we need the redundant "Data" here. It should be "Internet connection, MMS, A-GPS and Marketplace payments". Thanks
Comment 10•11 years ago
|
||
Removing the UX team flag since Carrie has responded. Thanks Carrie!
Flags: needinfo?(firefoxos-ux-bugzilla)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #8) > I filed bug 950307 to rename this string, since it was changed without > renaming the ID. > > Doubt about the last screenshot: is the repetition of "Data" really > necessary/wanted? Hi flod, it seems that UX needs to change the string again so there is no need for l10n team to change the string mentioned at Bug 950307 because I will put a new id for this. I will create another id in v1.3 for this change and l10n team will notice this, and also, I will update the string directly on master to reflect this change. In this way, I think we can just rename Bug 950307 and update its description to track this change. Thanks :)
Comment 12•10 years ago
|
||
Verified on Fugu, passed. Gaia a119a0692c24c5ed7c55bab838bae3ecdb9dbec9 Gecko 15ee4e78431b45922b41dea882464b0ccb6b4fac BuildID 20140110174141 Version 28.0a2
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → fixed
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•