947448 - Define nsXPCWrappedJS::IsRootWrapper() method

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

If a wrapped JS's root is the wrapper itself, then it is the root wrapper.  This is checked a number of places, but having it as an explicitly defined predicate makes it clearer what is happening, without needing comments all over the place.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Define and use nsXPCWrappedJS::IsRootWrapper.

Comment 2

[Andrew McCreight [:mccr8]]

l64 debug try run: https://tbpl.mozilla.org/?tree=Try&rev=bbbd2b63b1ef

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8344213 [details] [diff] [review]
Define and use nsXPCWrappedJS::IsRootWrapper.

Review of attachment 8344213 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCWrappedJS.cpp
@@ +545,5 @@
>  #ifdef DEBUG
>      XPC_LOG_ALWAYS(("nsXPCWrappedJS @ %x with mRefCnt = %d", this, mRefCnt.get()));
>          XPC_LOG_INDENT();
>  
> +        bool isRoot = IsRootWrapper();

seems like we could just nix isRoot here and inline IsRootWrapper(). Not that it matters much...

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Bobby Holley (:bholley) from comment #3)
> seems like we could just nix isRoot here and inline IsRootWrapper(). Not
> that it matters much...
Fixed.

Thanks for the various reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d80dc68e35a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d80dc68e35a