Closed Bug 947449 Opened 7 years ago Closed 7 years ago

Phonedash - change tooltip to display full build date time.

Categories

(Testing :: Autophone, enhancement)

x86_64
Linux
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch v1 (obsolete) — Splinter Review
It's kind of shiny but kind of ugly too. But it works for me! ;-)
Attachment #8344003 - Flags: review?(mcote)
Attached patch patch v2 (obsolete) — Splinter Review
less shiny, more compat.
Attachment #8344003 - Attachment is obsolete: true
Attachment #8344003 - Flags: review?(mcote)
Attachment #8344042 - Flags: review?(mcote)
Comment on attachment 8344042 [details] [diff] [review]
patch v2

Review of attachment 8344042 [details] [diff] [review]:
-----------------------------------------------------------------

Please patch ISODateString() in app.js to be able to optionally display the time as well and use that.  Might have to move it to another file.
Attachment #8344042 - Flags: review?(mcote) → review-
Attached patch patch v3Splinter Review
use dateStr instead.
Attachment #8344056 - Flags: review?(mcote)
Attachment #8344056 - Flags: review?(mcote) → review+
Attachment #8344042 - Attachment is obsolete: true
https://github.com/markrcote/phonedash/commit/533c50eaa6c981db2e66e7a8bfd8c09eb5950365
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.